Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slices.Delete #1645

Closed
Deleplace opened this issue Sep 20, 2023 · 2 comments · Fixed by #1646
Closed

slices.Delete #1645

Deleplace opened this issue Sep 20, 2023 · 2 comments · Fixed by #1646

Comments

@Deleplace
Copy link

Deleplace commented Sep 20, 2023 •
edited
Loading

Hello, while researching for this Go proposal I noticed this code:

slices.Delete(cacheEntry, i, i)

which probably doesn't behave as intended and should look like this instead:

cacheEntry = slices.Delete(cacheEntry, i, i+1)

(2 differences: using the returned value, and deleting +1 element instead of zero).

I have not tried to execute it.
@andrewpollock
Copy link
Contributor

Thank you so much for bringing this to my attention!

andrewpollock added a commit to andrewpollock/osv.dev that referenced this issue Sep 20, 2023
@andrewpollock
Correctly use the return value of slices.Delete
e04f1b2 
Fixes: google#1645
@andrewpollock andrewpollock mentioned this issue Sep 20, 2023
Merged
@Deleplace
Copy link
Author

See my comment in #1646 : i+1 as last arg would be more appropriate

andrewpollock added a commit that referenced this issue Sep 25, 2023
@andrewpollock
Correctly use the return value of slices.Delete (#1646)
d3b42d7 
Fixes: #1645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly use the return value of slices.Delete andrewpollock/osv.dev
2 participants
@andrewpollock @Deleplace