Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Keyframing #110

Open
robinsonkwame opened this issue Nov 27, 2024 · 1 comment
Open

[Question] Keyframing #110

robinsonkwame opened this issue Nov 27, 2024 · 1 comment

Comments

@robinsonkwame
Copy link

Great work! I had a question after reading the technical report, on keyframing. Has this feature been considered further? Several other projects, such as War and Peace, seems to approach the issue but not as systematically as your paper touches upon it.

@jzleibo
Copy link
Collaborator

jzleibo commented Nov 27, 2024

Interesting question, the 'scene' mechanism, which we added after writing that sentence in the tech report has, at least for our purposes so far, seemed to be the right idiom to handle the same underlying issue which the keyframes were meant to handle.

Here is an example of how scenes can be used to structure the simulation:
https://github.com/google-deepmind/concordia/blob/main/examples/modular/environment/labor_collective_action.py#L502-L533

Of course keyframes would be for a somewhat different purpose though. We just found that we didn't feel like we still needed keyframes after we added scenes. But maybe we're wrong and some situation will arise that will make us want to add them. This is a fast developing space.. We'll see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants