AWS Load Balancer Controller ssl redirect using annotation #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pshanoop there's one conflict in here, but if you can fix that, this PR is ready to go 😄 |
Co-authored-by: Aaron Schlesinger <[email protected]>
|
@arschles I didn't see your first comment. Fixed conflict and typo. Thanks for reviewing. 👍🏾 |
|
Hi @pshanoop Would you be able to update the base-branch and I will be able to merge it after that. thanks! |
|
Hey @pshanoop , is this still an issue? And if so, are you willing to do a new PR on the new Chart repo? https://github.com/gomods/athens-charts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Adds support for AWS Load Balancer Controller ssl-redirect using annotation
How is the fix applied?
Added new value
.Values.ingress.extraPathwhere we can specify customeserviveNameandservicePort. This way we can have ssl-redirect mentioned by AWS Load Balancer Controller documentationAnother value added
.Values.ingress.customPathto customize default path for service, ALB uses glob matching so to match all paths we need default path as/*.What GitHub issue(s) does this PR fix or close?
Fixes gomods/athens-charts#28