-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the download mode file from the helm chart #27
Comments
I will work on this next week, unless someone would like to work on it in that time frame |
Current syntax is |
@arschles How about treat ATHENS_DOWNLOAD_MODE without prefix as the content of download mode file, this will be way easier configEnvVars can already ref from secret or configMap, allowed plain hcl in env is ok. |
I very vaguely remember this conversation, but 👍 from me. Seems like a reasonable change. |
related to #8 |
Is your feature request related to a problem? Please describe.
The only way to set the download mode file from the helm chart currently is to set it with
configEnvVars.ATHENS_DOWNLOAD_MODE="base64:<base64 encoded file>"
. This obviously requires you to base64 encode the download file before putting it into the helm chart.You can also point Athens to an existing download mode file on disk, but
configEnvVars
doesn't give you a way to mount a download mode file (i.e. from a config map)Describe the solution you'd like
I'd like to allow for two things in the helm chart
Describe alternatives you've considered
Not doing this and just sticking with the
base64:
strategyAdditional context
cc/ @dsexton @dylan-bourque @twexler since we talked about this on slack
The text was updated successfully, but these errors were encountered: