From a6844bb4054979c17bbfdbaf4dc4c6c510a6c170 Mon Sep 17 00:00:00 2001 From: Sanian <76259603+Sanian-Creations@users.noreply.github.com> Date: Fri, 10 May 2024 18:18:45 +0200 Subject: [PATCH 1/3] Large outputs now show vertical scrollbar The calc(100% - 52px) corrects for the 32px that the .output element sticks out below the bottom of the page, and 20px for for the 10px padding that all pre tags have on the top and bottom. If this isn't corrected for then the vertical scrollbar is rendered below the bottom of the page. --- _content/tour/static/css/app.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/_content/tour/static/css/app.css b/_content/tour/static/css/app.css index c8cd9db7ed..722485bcfe 100755 --- a/_content/tour/static/css/app.css +++ b/_content/tour/static/css/app.css @@ -317,6 +317,8 @@ a#run, a#kill { font-family: 'Inconsolata', monospace; background: #fafafa; margin: 0; + overflow: auto; + max-height: calc(100% - 52px); } .output .system { color: #888; From 8a9aabcc95aefa504a6ec55ed8da4affb9de9301 Mon Sep 17 00:00:00 2001 From: Sanian <76259603+Sanian-Creations@users.noreply.github.com> Date: Sat, 11 May 2024 23:03:21 +0200 Subject: [PATCH 2/3] Update app.css Fixed root cause of issue: the `#explorer + div` element was sticking out 32px below the page, not anymore. `.output > pre` now uses box-sizing so that max-height 100% will always work regardless of any specific padding. --- _content/tour/static/css/app.css | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/_content/tour/static/css/app.css b/_content/tour/static/css/app.css index 722485bcfe..d759d5df80 100755 --- a/_content/tour/static/css/app.css +++ b/_content/tour/static/css/app.css @@ -318,7 +318,8 @@ a#run, a#kill { background: #fafafa; margin: 0; overflow: auto; - max-height: calc(100% - 52px); + max-height: 100%; + box-sizing: border-box; } .output .system { color: #888; @@ -518,6 +519,7 @@ a#run, a#kill { } #explorer + div { top: 32px; + height: calc(100% - 32px); } #file-menu { position: absolute; From 6f7ecd3606d46b2370c294e9bf1e8c03f1404484 Mon Sep 17 00:00:00 2001 From: Sanian <76259603+Sanian-Creations@users.noreply.github.com> Date: Sat, 11 May 2024 23:32:52 +0200 Subject: [PATCH 3/3] Update app.css change is now minimal --- _content/tour/static/css/app.css | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/_content/tour/static/css/app.css b/_content/tour/static/css/app.css index d759d5df80..b422bde51a 100755 --- a/_content/tour/static/css/app.css +++ b/_content/tour/static/css/app.css @@ -317,9 +317,7 @@ a#run, a#kill { font-family: 'Inconsolata', monospace; background: #fafafa; margin: 0; - overflow: auto; - max-height: 100%; - box-sizing: border-box; + min-width: min-content; } .output .system { color: #888;