Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only a few versions are returned by 'Choose Go Environment' #1743

Open
bkmeneguello opened this issue Sep 1, 2021 · 4 comments · May be fixed by #1744
Open

Only a few versions are returned by 'Choose Go Environment' #1743

bkmeneguello opened this issue Sep 1, 2021 · 4 comments · May be fixed by #1744
Labels
FeatureRequest
Milestone
vscode-go/unplanned

Comments

@bkmeneguello
Copy link

I suggest to add '&include=all' to the download URL at Choose Go Environment, so it could download any version.
@gopherbot gopherbot added this to the Untriaged milestone Sep 1, 2021
bkmeneguello added a commit to bkmeneguello/vscode-go that referenced this issue Sep 1, 2021
@bkmeneguello
Include all versions from golang.org/dl in 'Choose Go Environment'
c944b91 
fixes golang#1743
@bkmeneguello bkmeneguello linked a pull request Sep 1, 2021 that will close this issue
Open
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/347032 mentions this issue: src/goEnvironmentStatus.ts: include all versions from golang.org/dl

@hyangah
Copy link
Contributor

hyangah commented Sep 2, 2021

Thanks for the PR.
What versions were you interested in seeing in the list?
I wished this allowed easy access to latest RCs or tip the other day.
But I am afraid the list is too long and I hope we can hide very old versions from the list (I am not sure how well the extension supports go versions older than 1.12 at this stage).

@findleyr findleyr modified the milestones: Untriaged, Backlog Sep 2, 2021
@bkmeneguello
Copy link
Author

Well, I'm not really aware of the extension limitations on older versions, but I recently had to install the 1.13 version, which made me to think about this.
Since we cannot determine the use cases, and since it's possible to install all those versions, I think we should allow.

@hyangah
Copy link
Contributor

hyangah commented Sep 3, 2021

What do you think if we have an option that takes a go version string and downloads that version?
The list from dl with include=all is too long. Without clear use cases and justification, I'd like to avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest
Projects
None yet
Milestone
vscode-go/unplanned
Development

Successfully merging a pull request may close this issue.

src/goEnvironmentStatus.ts: include all versions from golang.org/dl bkmeneguello/vscode-go
4 participants
@bkmeneguello @hyangah @gopherbot @findleyr