This PR (HEAD: 1356317) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638395.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Mateusz Poliwczak:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T10:57:26Z","revision":"b5bb1228ab5860114a9b1262a1040aa67bf51587"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Mateusz Poliwczak:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

• go on master (change 638395)
• tools on master (commit ebeac1b)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727855844223698145.

Additional links for debugging:

• Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Alan Donovan:

Patch Set 1: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 91e1236) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638395.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Message from Mateusz Poliwczak:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T16:59:57Z","revision":"948d5b3abd7fd54eb9293c72cf83fb443efd95d1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Mateusz Poliwczak:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

• go on master (change 638395)
• tools on master (commit ebeac1b)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727833017614781521.

Additional links for debugging:

• Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!

Message from Mateusz Poliwczak:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638395.
After addressing review feedback, remember to publish your drafts!