-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Infer
as a new Security Test
#542
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @thepabloaguilar! I made a few comments on your code 😊
fc3a787
to
b7e585f
Compare
mkdir -p ~/.ssh && | ||
echo '%GIT_PRIVATE_SSH_KEY%' > ~/.ssh/huskyci_id_rsa && | ||
chmod 600 ~/.ssh/huskyci_id_rsa && | ||
echo "IdentityFile ~/.ssh/huskyci_id_rsa" >> /etc/ssh/ssh_config && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @thepabloaguilar ! I tried to run an analysis using infer and received a few errors. The /etc/ssh
directory does not exist in this image, so I was getting an error when trying to write to a file inside it. Could you check if there is any command missing here?
# mkdir the man/man1 directory due to Debian bug #863199 | ||
RUN apt-get update \ | ||
&& mkdir -p /usr/share/man/man1 \ | ||
&& apt-get install --yes --no-install-recommends \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the git
installation is missing here. While debugging errors inside the container I couldn't clone the repository because git
wasn't available.
Description
Adds
Infer
as a new Security TestProposed Changes
There are no breaking changes here!
Testing
Infer
will work for Java projects, in order to test you need to setup huskyCI locally and runmake run-client-linux
using some Java repo!Closes #511