Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/v24.12 10 #6335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hotfix/v24.12 10 #6335

wants to merge 1 commit into from

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Dec 24, 2024 •
edited by azure-boards bot
Loading

AB#32390

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 24, 2024 07:52
Copilot
Copilot AI reviewed Dec 24, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (8)
  • interfaces/Portal/src/assets/i18n/ar.json: Language not supported
  • interfaces/Portal/src/assets/i18n/en.json: Language not supported
  • interfaces/Portal/src/assets/i18n/es.json: Language not supported
  • interfaces/Portal/src/assets/i18n/fr.json: Language not supported
  • interfaces/Portal/src/assets/i18n/nl.json: Language not supported
  • interfaces/Portal/src/assets/i18n/ru.json: Language not supported
  • services/121-service/src/payments/fsp-integration/intersolve-visa/mappers/visa-card-121-status-map.csv: Language not supported
  • services/121-service/test/program/snapshots/create-program.test.ts.snap: Language not supported
Comments suppressed due to low confidence (1)

services/121-service/src/program-attributes/program-attributes.service.ts:36

  • [nitpick] The variable name 'programFinancialServiceProviderConfigurationName' is quite long and might be confusing. Consider renaming it to something shorter and more descriptive.
'programFinancialServiceProviderConfigurationName',

...es/121-service/src/payments/fsp-integration/intersolve-voucher/intersolve-voucher.service.ts Outdated Show resolved Hide resolved
@RubenGeo RubenGeo added the bugfix Something that affects our end users is fixed label Dec 24, 2024
@RubenGeo RubenGeo temporarily deployed to client-southafrica December 24, 2024 07:58 — with GitHub Actions Inactive
@RubenGeo RubenGeo deployed to client-southafrica December 24, 2024 07:58 — with GitHub Actions Active
@RubenGeo RubenGeo temporarily deployed to client-southsudan December 24, 2024 07:59 — with GitHub Actions Inactive
@RubenGeo RubenGeo deployed to client-southsudan December 24, 2024 07:59 — with GitHub Actions Active
@RubenGeo RubenGeo deployed to client-zambia December 24, 2024 07:59 — with GitHub Actions Active
@RubenGeo RubenGeo deployed to client-zimbabwe December 24, 2024 07:59 — with GitHub Actions Active
@RubenGeo RubenGeo mentioned this pull request Dec 24, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Something that affects our end users is fixed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RubenGeo