Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v6 TODO #65

Closed
glacials opened this issue Oct 1, 2017 · 3 comments
Closed

API v6 TODO #65

glacials opened this issue Oct 1, 2017 · 3 comments

Comments

@glacials
Copy link
Owner

glacials commented Oct 1, 2017

Definitely way too soon and very little reason to bump API versions, but when it does happen this is a living list of things to remember to change.

  • Change API from snake_case to camelCase per Google's JSON style guide
@glacials
Copy link
Owner Author

glacials commented May 21, 2018

Few new items:

  • Ravnica Allegience has a month of release ("January 2019") but no date. The API should either allow partial dates or allow enter_date to be null.
  • Unofficial blocks: there are three Ravnica sets coming, all blockless because blocks don't exist but thematically together. Should we express that in the API? Maybe optionally.
  • As-of-yet unnamed sets: Again using Ravnica as an example, we are expecting three Ravnica sets but we only have the names of the first two. It would be nice to be able to display the fact that we are expecting one more, even without knowing its name, release date, rough release date, code, etc. (this one I'm not so sure about). (EDIT: We also now know about Core 2020, the set after the last Ravnica set, but we can't insert it into the API because of this issue. That would be an added benefit here.)
  • On that note, kill the block field if all the sets that use it have dropped by the time v6 is implemented.
  • Nation-specific legality: The recent China announcement makes determining what is in Standard a country-specific question. If you're in China the answer is different from if you're anywhere else. The API probably needs to support this.

@silasary
Copy link
Contributor

"Archery" releases on October 4, 2019, but because we don't have a name yet, it's not in the API.

@glacials
Copy link
Owner Author

glacials commented Jul 18, 2019

I've just released v6 and addressed all these issues except nation-specific legality and thematic blocks. These two items aren't vital and could be added later with a non-breaking change, so for now I'll forward them on to the equivalent v7 issue (#138).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants