Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails can be obviously not emails #777

Open
glacials opened this issue Aug 3, 2021 · 0 comments
Open

Emails can be obviously not emails #777

glacials opened this issue Aug 3, 2021 · 0 comments
Labels
feature Issues that are solved by adding new functionality for users good first issue Issues that don't need a ton of context to address

Comments

@glacials
Copy link
Owner

glacials commented Aug 3, 2021

Had a user confused that they were not able to log in with any email address of theirs, so I went to look it up and the user had supplied a username, not an email address, for the email address field (no @ etc.).

I subscribe to the thought that the best way to validate that a string is an email address is to try to send an email to it, not go down the rabbit hole of giant complex regexes that always get proven wrong, but a low-effort thing like validating that there's an @, maybe a ., in it to prevent user mistakes like this seems reasonable.

@glacials glacials added feature Issues that are solved by adding new functionality for users good first issue Issues that don't need a ton of context to address labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that are solved by adding new functionality for users good first issue Issues that don't need a ton of context to address
Projects
None yet
Development

No branches or pull requests

1 participant