Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUNDING.yml custom links does not include information on valid formats #35690

Open
1 task done
andrewnicols opened this issue Dec 17, 2024 · 5 comments
Open
1 task done
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review

Comments

@andrewnicols
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository#about-funding-files

What part(s) of the article would you like to see updated?

The sections on Custom URLs do not provide adequate information on the valid formats for a URL.

The following is the entire information:

Custom URL | custom: LINK1 or custom: [LINK1, LINK2, LINK3, LINK4]
Here's an example FUNDING.yml file:

github: [octocat, surftocat]
patreon: octocat
tidelift: npm/octo-package
custom: ["https://www.paypal.me/octocat", octocat.com]

Note
If a custom URL in an array includes :, you must wrap the URL in quotes. For example, "https://www.paypal.me/octocat".

The example, and the last note suggests that valid custom URL formats include values such as:

  • octocat.com
  • octocat.com/example
  • octocat.com/example/#fund-me

However there is no schema validation to confirm this.

We encountered this as Packagist treats all of the above valid examples as invalid due to the lack of scheme:
composer/composer#12244

Additional information

No response

@andrewnicols andrewnicols added the content This issue or pull request belongs to the Docs Content team label Dec 17, 2024
Copy link

welcome bot commented Dec 17, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 17, 2024
@kristina-zd

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Dec 17, 2024
@nguyenalex836
Copy link
Contributor

@andrewnicols Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@andrewnicols
Copy link
Author

Thanks,

As @stof has pointed out on composer/composer#12245 the current value is treated as a path due to the lack of scheme.

If the value is expected to be manipulated in some way to be useful this needs to be detailed. I assume that if it is missing the scheme then the expectation is that it should be prefixed with https:// but this isn't clear and I can't find any validation for it either.

@felicitymay felicitymay added the needs SME This proposal needs review from a subject matter expert label Dec 20, 2024
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

4 participants