Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gren changelog not finding all releases #308

Open
paul-uz opened this issue Nov 23, 2021 · 4 comments
Open

gren changelog not finding all releases #308

paul-uz opened this issue Nov 23, 2021 · 4 comments

Comments

@paul-uz
Copy link

paul-uz commented Nov 23, 2021

I have a private repo with 40+ releases, but running gren changelog only finds 30 releases.

All releases follow the same versioning format, x.y.z

@paul-uz
Copy link
Author

paul-uz commented Nov 23, 2021

I tried with --limit 100 but the debug info still says 30

gren changelog -o -D prs --limit 100 -B

Options: 
Tags: empty
Prefix: empty
Template: [object Object]
Prerelease: false
Generate: false
Quiet: false
Override: true
Debug: true
Ignore labels: empty
Ignore issues with: empty
Ignore commits with: empty
Group by: false
Milestone match: Release {{tag_name}}
Changelog filename: CHANGELOG.md
Username: Foobar
Repo: XYZ
Token: XXX
Limit: 30
Data source: prs
Include messages: commits
Ignore tags with: empty

@paul-uz
Copy link
Author

paul-uz commented Nov 23, 2021

Limit does work, for numbers <= 99. As soon as you try 100, it defaults back to 30

@mv-coder
Copy link

That is, because there is a MAX_TAGS_LIMIT = 99 in https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js. If you go beyond that, it will revert to the default TAGS_LIMIT = 30.

@paul-uz
Copy link
Author

paul-uz commented Nov 26, 2021

Well, thats a bit daft isn't it. And not mentioned in the documentation 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants