Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to maintained PHP syntax highlighter #5668

Closed
ondrejmirtes opened this issue Dec 1, 2021 · 2 comments
Closed

Switch to maintained PHP syntax highlighter #5668

ondrejmirtes opened this issue Dec 1, 2021 · 2 comments

Comments

@ondrejmirtes
Copy link
Contributor

Describe the enhancement

It seems like Linguist is using this repository https://github.com/textmate/php.tmbundle for its PHP syntax highlighting.

There has been a pull request open for highlighting PHP 8.0 features for more than a year: textmate/php.tmbundle#88

Are the maintainers of Linguist interested in switching to a fork of that repository which would be more actively maintained? PHP 8.1 is now out with even more keywords to be highlighted, and it'd be great to be up-to-date.

I could create the fork and maintain it. Thanks.

@lildude
Copy link
Member

lildude commented Dec 1, 2021

Are the maintainers of Linguist interested in switching to a fork of that repository which would be more actively maintained?

Definitely! Go for it and send us a PR to change there source we use.

@ondrejmirtes
Copy link
Contributor Author

My PR has been merged, thank you :)

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants