Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve maven install process #91

Open
physikerwelt opened this issue Dec 21, 2015 · 0 comments
Open

improve maven install process #91

physikerwelt opened this issue Dec 21, 2015 · 0 comments
Assignees

Comments

@physikerwelt
Copy link
Member

as discussed on skype
[16:25:32] Moritz Schubotz: thank you travis is happy now
[16:25:47] Alexey Grigorev: great!
[16:26:18] Moritz Schubotz: at least.. if the committed code is correct;-)
[16:26:19] Moritz Schubotz: https://travis-ci.org/TU-Berlin/mathosphere/builds
[16:26:33] Moritz Schubotz: it takes 30 min though
[16:28:03] Moritz Schubotz: on my unix test Server it only takes 1:42.092
[16:28:04] Alexey Grigorev: I think it's because of building an uber jar
[16:28:34] Alexey Grigorev: but I have no idea why on your server it's fast
[16:29:16] Alexey Grigorev: i'd turn building uber jar altogether, but it's also used in many modules
[16:29:17] Moritz Schubotz: i guess better hardware
[16:29:20] Moritz Schubotz: as simple as that
[16:29:24 | Edited 16:29:28] Alexey Grigorev: maybe
[16:29:42] Alexey Grigorev: but the difference is too big
[16:30:06] Alexey Grigorev: on the server do you buld the parent?
[16:30:16] Alexey Grigorev: or just mathosphere?
[16:30:41] Moritz Schubotz: that was just mathosphere-core
[16:31:19] Alexey Grigorev: thats the reason
[16:31:31] Alexey Grigorev: i think
[16:32:17] Moritz Schubotz: the full build takes 4 min
[16:32:45] Moritz Schubotz: but however
[16:33:06] Moritz Schubotz: i'd turn building uber jar altogether, but it's also used in many modules
[16:33:11] Moritz Schubotz: what do you mean by that
[16:33:32] Alexey Grigorev: the build plugin puts all dependencies in one jar
[16:33:57] Alexey Grigorev: it was mostly its output in maven
[16:34:09] Moritz Schubotz: but what's your Suggestion?
[16:34:14] Alexey Grigorev: remove it
[16:34:31] Alexey Grigorev: or from parent to core
[16:34:40] Alexey Grigorev: move from *
[16:35:00] Moritz Schubotz: can you do a pull request
[16:35:09] Alexey Grigorev: not today
[16:35:18] Alexey Grigorev: but i can play with it
[16:35:20] Moritz Schubotz: the core ueber jar might be required to run it on a full cluster
[16:35:33] Moritz Schubotz: otherwise dependencies might be missing
[16:35:36] Alexey Grigorev: only for core
[16:35:46] Moritz Schubotz: yes
[16:35:50] Alexey Grigorev: I'd remove it ftom tests
[16:36:12] Alexey Grigorev: and build it with special instruction like -Puber
[16:36:22] Alexey Grigorev: or smth like this
[16:36:27] Moritz Schubotz: yes that would be great
[16:36:37] Moritz Schubotz: similar to the Profile for publish on maven central
[16:36:59] Alexey Grigorev: yes
[16:37:10] Alexey Grigorev: could you create an issue and assign to me?
[16:37:16] Moritz Schubotz: we do not Need that today, but it would be great in general
[16:37:27] Alexey Grigorev: so i don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants