Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token value < 60 breaks itokens #73

Open
ctrochalakis opened this issue Jan 22, 2015 · 3 comments
Open

Token value < 60 breaks itokens #73

ctrochalakis opened this issue Jan 22, 2015 · 3 comments

Comments

@ctrochalakis
Copy link

The itoken expiration time is set by the following code:
self.itoken_expires = time() + self.token_life - 60

That effectively means that setting token_life to a value less than60 secs results in a token with an expiration date set in the past.

Is there a reason to subtract 60 secs from the token_life value? Perhaps it should be dropped.

@ctrochalakis ctrochalakis changed the title Token value < 60 doesn't work Token value < 60 breaks itokens Jan 22, 2015
@gholt
Copy link
Owner

gholt commented Jan 23, 2015

Hmm. I checked the history on that line and -- after 4 years and the initial commit being the only commit for that line -- I honestly have no idea why the 60 is there. I guess nobody's ever set the token_life to under 60 seconds before either. =)

@ctrochalakis
Copy link
Author

Hehe! We set it to 60secs so we could debug a driver's retry logic when the token has expired.

@onovy
Copy link
Contributor

onovy commented Nov 17, 2015

review for removing it here: https://review.openstack.org/246342
comments welcome

openstack-gerrit pushed a commit to openstack-archive/swauth that referenced this issue Nov 20, 2015
According to gholt/swauth#73 nobody
knows why is this here. Let's try to remove it :).

Change-Id: I6de2c7eca5b7c4cbed61c966149055705efe8323
mscherer pushed a commit to gluster/gluster-swift that referenced this issue Mar 12, 2016
According to gholt/swauth#73 nobody
knows why is this here. Let's try to remove it :).

This is ported from following commit in swauth repo:
79c153f7b198ffaf0c3fd781587a0133bab43d7f

Change-Id: I8e64b53ed59dab1f554b7c08f1342c2b5dd4675a
Signed-off-by: Prashanth Pai <[email protected]>
Reviewed-on: http://review.gluster.org/13522
Reviewed-by: Thiago da Silva <[email protected]>
Tested-by: Thiago da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants