-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token value < 60 breaks itokens #73
Comments
Hmm. I checked the history on that line and -- after 4 years and the initial commit being the only commit for that line -- I honestly have no idea why the 60 is there. I guess nobody's ever set the token_life to under 60 seconds before either. =) |
Hehe! We set it to 60secs so we could debug a driver's retry logic when the token has expired. |
review for removing it here: https://review.openstack.org/246342 |
According to gholt/swauth#73 nobody knows why is this here. Let's try to remove it :). Change-Id: I6de2c7eca5b7c4cbed61c966149055705efe8323
According to gholt/swauth#73 nobody knows why is this here. Let's try to remove it :). This is ported from following commit in swauth repo: 79c153f7b198ffaf0c3fd781587a0133bab43d7f Change-Id: I8e64b53ed59dab1f554b7c08f1342c2b5dd4675a Signed-off-by: Prashanth Pai <[email protected]> Reviewed-on: http://review.gluster.org/13522 Reviewed-by: Thiago da Silva <[email protected]> Tested-by: Thiago da Silva <[email protected]>
The itoken expiration time is set by the following code:
self.itoken_expires = time() + self.token_life - 60
That effectively means that setting token_life to a value less than
60 secs
results in a token with an expiration date set in the past.Is there a reason to subtract 60 secs from the token_life value? Perhaps it should be dropped.
The text was updated successfully, but these errors were encountered: