Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggml : add FFT operator #1049

Open
ggerganov opened this issue Dec 14, 2024 · 1 comment
Open

ggml : add FFT operator #1049

ggerganov opened this issue Dec 14, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ggerganov
Copy link
Owner

It would be nice to have a simple implementation of FFT. The main goal is to be able to keep the data inside a ggml graph in certain scenarios (such as in Whisper and various TTS models), even if the performance is not as good as dedicated libraries (such as FFTW and cuFFT). I think we can start with a basic Cooley-Tukey implementation to keep things simple. Batched 1D FFT should be supported, as well as common variations such as inverse FFT and real-valued FFT.

@ggerganov ggerganov added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2024
@ggerganov ggerganov moved this to Todo in ggml : roadmap Dec 14, 2024
@maedoc
Copy link

maedoc commented Dec 24, 2024

I'm interested in trying but don't see any complex number support in ggml so far (IIUC). Just curious if there's any thought so far about data layout (separate, interleaved etc). Seems like the easiest initial approach would be to just keep the real & imag parts separate and imag part optional for some ops in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants