Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links on in the documentation #327

Merged
merged 2 commits into from
May 26, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Change and fix some broken links in the documentation to ensure the link checker can detect broken links in the future.

What issue does it fix

Related to getporter/porter#3027

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you make any API changes? Update the corresponding API documentation.

Change and fix some broken links in the documentation to ensure the link
checker can detect broken links in the future.

Signed-off-by: Kim Christensen <[email protected]>
Copy link
Collaborator

@sgettys sgettys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you test these resolve locally and in the pre-release netlify?

Signed-off-by: Kim Christensen <[email protected]>
@kichristensen
Copy link
Contributor Author

LGTM, did you test these resolve locally and in the pre-release netlify?

I have tested it locally, haven't tested in in the preview Netlify as the scripts clone the operator repository everytime to get the latest version.

@kichristensen kichristensen merged commit 4ed0f9d into getporter:main May 26, 2024
6 checks passed
@kichristensen kichristensen deleted the fixLinksInDocs branch May 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants