Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further reduce the code #2

Open
3 tasks done
chainsawriot opened this issue Mar 12, 2024 · 5 comments
Open
3 tasks done

Further reduce the code #2

chainsawriot opened this issue Mar 12, 2024 · 5 comments

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Mar 12, 2024 •
edited
Loading

  • Evaluate which files / lines in src can be removed
  • R code clean up?
  • Help file clean up
@chainsawriot
Copy link
Collaborator Author

https://github.com/chainsawriot/minty/blob/c6eeda308afeb65f201927a67cfee02931fc82dd/R/cpp11.R#L3-L37

Among the exported C++ functions, just type_convert_col, parse_vector_, guess_header_, utctime_ (questionable whether it is actually used), collectorGuess are used in the R code.

@chainsawriot chainsawriot reopened this Mar 14, 2024
@chainsawriot
Copy link
Collaborator Author

C++ files with zero coverage (probably not used.)

src/grisu3.c: 0.00%
src/init.c: 0.00%
src/mio.h: 0.00%
src/Source.cpp: 0.00%
src/Source.h: 0.00%
src/SourceFile.h: 0.00%
src/SourceRaw.h: 0.00%
src/SourceString.h: 0.00%
src/Tokenizer.cpp: 0.00%
src/Tokenizer.h: 0.00%
src/TokenizerDelim.cpp: 0.00%
src/TokenizerFwf.cpp: 0.00%
src/TokenizerLine.h: 0.00%
src/TokenizerLog.h: 0.00%
src/TokenizerWs.cpp: 0.00%
src/unicode_fopen.h: 0.00%

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Mar 14, 2024 •
edited
Loading

  • guess_header_ can be removed

chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
clean up src ref #2
b159c33
chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
clean up src ref #2 (#14)
4e5422f
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Mar 15, 2024 •
edited
Loading

  • utctime_ can be removed

chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
Remove utctime ref #2
1b82f15
chainsawriot added a commit that referenced this issue Mar 15, 2024
@chainsawriot
Remove utctime ref #2 (#15)
2b5347b
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Mar 15, 2024 •
edited
Loading

  • remove this

https://github.com/chainsawriot/minty/blob/2b5347b2a19b1447de0fc853df4a543f8a86ef9c/R/type_convert.R#L14-L16

@chainsawriot chainsawriot mentioned this issue Mar 15, 2024
Open
chainsawriot added a commit that referenced this issue Mar 18, 2024
@chainsawriot
Further clean up ref #2
23bee33
chainsawriot added a commit that referenced this issue Mar 18, 2024
@chainsawriot
Further clean up ref #2 (#19)
912bb36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot