Some upgrades don't seem to be working anymore

[NathanLovato]

Following my refactor of the stats and upgrades, the states, e.g. in PlayerShip, upgrades don't seem to be changing the gameplay. I haven't spent a lot of time investigating, but this might be due to not updating values from the Stats class, for example in a given state. We have to either:

• Always call *.stats.get_stat("stat_name")
• Have objects subscribe to stats' stat_changed signal and update a property accordingly

[Razoric480]

For the GSAIKinematicBodyAgent2D, it'll need to be via the stat_changed signal, since those values are built into the steering framework.

[Hansel-Dsilva]

Seems like a serious bug. Any advice on how to go about debugging this? Perhaps I can compare the code with that before the refactor commit.

[NathanLovato]

I have to check again, this might be solved already. There's more refactoring to do for the upgrade system but for now, we're busy with other projects.

[Hansel-Dsilva]

I've manually play tested all the upgrades and the stats' cache dictionary seems to be updating properly. _cache is where all the current stats are located right? If so then this issue can be closed. Unless, the _cache updates don't actually change the gameplay? I can't tell because of the lack of any numerical feedback in-game. The health bar & cargo circle don't get bigger but I guess that's how the GUI is set up.

[NathanLovato]

The stats are the stats, but concrete movement speed is being handled by the steering ai framework. I'll check it right away

[NathanLovato]

The issue is still there. Notes to address it:

In the player's Move.gd state, we need to update the linear_speed_max and acceleration_max when the corresponding stat changes on the ship. This requires adding signals to the stats (signal linear_speed_max_changed(new_speed) etc. to connect them to the move state.

[Razoric480]

Could simplify it and just use the stats_changed signal and just re-apply all the variables.