Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segments todo's #1

Open
4 of 20 tasks
galvani opened this issue Feb 21, 2018 · 0 comments
Open
4 of 20 tasks

Segments todo's #1

galvani opened this issue Feb 21, 2018 · 0 comments
Assignees
@galvani @Maxell92

Comments

@galvani
Copy link
Owner

galvani commented Feb 21, 2018 •
edited
Loading

Welcome to the mautic wiki!

Found 20 TODO items in 9 files

ContactSegmentFilter.php

  • (161, 9) * @todo remove this, create functions to replace need for this
  • (252, 9) * @todo replace if not used DateDecorator.php
  • (24, 9) * @todo @petr please check this method FilterDecoratorInterface.php
  • (19, 5) * @todo @petr document these functions please with phpdoc and meaningful description OperatorOptions.php
  • (71, 17) // @todo implement in list UI
  • (78, 17) // @todo implement in list UI

ContactSegmentQueryBuilder.php

  • (23, 5) * @todo add exceptions, remove related segments
  • (150, 43) * @param $whatever @todo document this field
  • (236, 9) * @todo Remove this function
  • (248, 9) * @todo Remove this function
  • (260, 9) * @todo Remove this function
  • (272, 9) * @todo Remove this function

BaseFilterQueryBuilder.php

  • (101, 24) //@todo this logic needs to

DoNotContactFilterQueryBuilder.php

  • (35, 12) //@todo look at this, the getCrate method is for debuggin only

ForeignFuncFilterQueryBuilder.php

  • (83, 24) //@todo this logic needs to

QueryBuilder.php

  • (39, 5) * @todo rework this to extend the original Query Builder instead of writing new one
  • (47, 5) * @todo extend standing class instead of redefining everything
  • (1414, 9) * @todo I need to rewrite it, it's no longer necessary like this, we have direct access to query parts
  • (1444, 9) * @todo I need to rewrite it, it's no longer necessary like this, we have direct access to query parts
  • (1678, 9) * @todo make this readable and explain
galvani pushed a commit that referenced this issue Apr 9, 2018
@heathdutton
Merge pull request #1 from mautic/staging
a8ec02f 
Update fork.
galvani pushed a commit that referenced this issue Aug 24, 2018
@scottshipman
Merge pull request #1 from mautic/staging
da42f71 
update staging from mautic staging
galvani pushed a commit that referenced this issue Sep 28, 2022
@escopecz @mollux
Adding Symfony 4.0 and 4.1 Rector rule sets to CI (mautic#11479)
5626b8d 
* Adding SYMFONY_40 Rector rule

* Refactoring $this->form to DI because Rector couldn't bare it

Error message:

Could not process "app/bundles/IntegrationsBundle/Controller/ConfigController.php" file, due to:
         "System error: "Rector\Symfony\Rector\MethodCall\FormIsValidRector::isIsSubmittedByAlreadyCalledOnVariable():
         Argument #1 ($variable) must be of type PhpParser\Node\Expr\Variable, PhpParser\Node\Expr\PropertyFetch given,
         called in vendor/rector/rector/vendor/rector/rector-symfony/src/Rector/MethodCall/FormIsValidRector.php:59"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On
         line: 86

* Adding also Symfony 4.1 ruleset as it does not change any code

* Typo fix

Co-authored-by: mollux <[email protected]>

Co-authored-by: mollux <[email protected]>
mabumusa1 pushed a commit that referenced this issue Feb 7, 2023
@escopecz
Fixing failing API-Library test for editing devices by PUT with ID th…
e5d85be 
…at does not work

TypeError: method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strpos(): Passing null to parameter #1 ($haystack) of type string is …
4e31e00 
…deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strtolower(): Passing null to parameter #1 ($string) of type string i…
5e63c23 
…s deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
rtrim(): Passing null to parameter #1 ($string) of type string is dep…
28fbf0a 
…recated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
htmlspecialchars_decode(): Passing null to parameter #1 ($string) of …
3a65cc5 
…type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
substr(): Passing null to parameter #1 ($string) of type string is de…
a2df021 
…precated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
nl2br(): Passing null to parameter #1 ($string) of type string is dep…
0f48bae 
…recated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
ucfirst(): Passing null to parameter #1 ($string) of type string is d…
71074db 
…eprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
trim(): Passing null to parameter #1 ($string) of type string is depr…
b4dc980 
…ecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
addcslashes(): Passing null to parameter #1 ($string) of type string …
d9f64be 
…is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
substr(): Passing null to parameter #1 ($string) of type string is de…
b085b06 
…precated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strnatcmp(): Passing null to parameter #1 ($string1) of type string i…
bfd373a 
…s deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Exception::__construct(): Passing null to parameter #1 ($message) of …
a19f17d 
…type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strpos(): Passing null to parameter #1 ($haystack) of type string is …
37691bd 
…deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
DateTime::format(): Passing null to parameter #1 ($format) of type st…
ec3b162 
…ring is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
base64_encode(): Passing null to parameter #1 ($string) of type strin…
342b832 
…g is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Exception::__construct(): Passing null to parameter #1 ($message) of …
32b07ce 
…type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
rtrim(): Passing null to parameter #1 ($string) of type string is dep…
8d57fea 
…recated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Parameter #1 $text of static method Mautic\CoreBundle\Helper\EmojiHel…
0eef3ba 
…per::toEmoji() expects string, array given.
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Parameter #1 $text of static method Mautic\CoreBundle\Helper\EmojiHel…
e730205 
…per::toEmoji() expects string, array given.
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Argument #1 ($dsnMessage) must be of type string, null given
773d3f6
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
html_entity_decode(): Passing null to parameter #1 ($string) of type …
116b449 
…string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
html_entity_decode(): Passing null to parameter #1 ($string) of type …
77b2207 
…string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
trim(): Passing null to parameter #1 ($string) of type string is depr…
a1cbe19 
…ecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Exception::__construct(): Passing null to parameter #1 ($message) of …
c1b5639 
…type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
html_entity_decode(): Passing null to parameter #1 ($string) of type …
e03aca5 
…string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
Transliterator::transliterate(): Passing null to parameter #1 ($strin…
4372a80 
…g) of type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strtolower(): Passing null to parameter #1 ($string) of type string i…
1d76fc9 
…s deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
substr(): Passing null to parameter #1 ($string) of type string is de…
2e9353f 
…precated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strtolower(): Passing null to parameter #1 ($string) of type string i…
f7044dc 
…s deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
strpos(): Passing null to parameter #1 ($haystack) of type string is …
dccb5a5 
…deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
DateTime::__construct(): Passing null to parameter #1 ($datetime) of …
7f6513c 
…type string is deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
parse_str(): Passing null to parameter #1 ($string) of type string is…
f23b1ec 
… deprecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
trim(): Passing null to parameter #1 ($string) of type string is depr…
d8b7c72 
…ecated
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
TypeError: Mautic\CoreBundle\Helper\InputHelper::alphanum(): Argument #1
130e30d 
 ($value) must be of type string, null given
galvani pushed a commit that referenced this issue Jun 12, 2023
@escopecz
json_decode(): Passing null to parameter #1 ($json) of type string is…
a958f8c 
… deprecated
galvani pushed a commit that referenced this issue Jul 26, 2023
@escopecz
strpos(): Passing null to parameter #1 ($haystack) of type string is …
32879dc 
…deprecated
galvani pushed a commit that referenced this issue Mar 22, 2024
@escopecz
Fixing replaceSignatureTokens(): Argument #1 ($signature) must be of …
3639945 
…type string, null given
galvani pushed a commit that referenced this issue Mar 22, 2024
@escopecz
Fixing setReplyToForSingleMessage(): Argument #1 ($emailToSend) must …
98af980 
…be of type Mautic\EmailBundle\Entity\Email, null given
galvani pushed a commit that referenced this issue Nov 25, 2024
@escopecz
Dropping support for PHP 8.0 (mautic#13972)
f455fc0 
* Dropping support for PHP 8.0

* STAN: Return type bool of method Mautic\CoreBundle\Session\Storage\Handler\RedisSentinelSessionHandler::gc() is not covariant with tentative return type int|false of method SessionHandlerInterface::gc()

* STAN: Parameter #1 $imap of function imap_ping expects IMAP\Connection, resource given.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galvani galvani

@Maxell92 Maxell92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galvani @Maxell92