Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support ed25519 encryption/decryption #47

Open
yogat3ch opened this issue Feb 3, 2022 · 3 comments
Open

Feature Request: Support ed25519 encryption/decryption #47

yogat3ch opened this issue Feb 3, 2022 · 3 comments
Labels
feature a feature request or enhancement

Comments

@yogat3ch
Copy link

yogat3ch commented Feb 3, 2022

Hi @gaborcsardi,
Github now recommends and defaults to ed25519 encryption when generating SSH keys.
Currently secret only supports rsa encryption. Are there plans to support ed25519 encryption and decryption?
@yogat3ch
Copy link
Author

yogat3ch commented Feb 3, 2022

Started it in #48. I'm going to be honest though and say up front that I have very little idea of what I'm doing in this regard.
Any guidance/help is welcome!

@yogat3ch
Copy link
Author

yogat3ch commented Feb 4, 2022

It looks at the very least revisions will need to occur in share_secret_with_key1 & store_secret_with_key to encrypt secrets, and get_secret for unencryption

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Nov 1, 2023
@gaborcsardi
Copy link
Owner

Thanks, and sorry for the very long wait, I'll look at the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaborcsardi @yogat3ch