Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite support implementation #69

Closed
wants to merge 1 commit into from
Closed

Sqlite support implementation #69

wants to merge 1 commit into from

Conversation

emrekara37
Copy link

@emrekara37 emrekara37 commented Apr 12, 2021 •
edited
Loading

Sqlite support implementation

Hi @furkandeveloper ,
I added support SQLite.

Thanks for the useful package

This change is Reviewable

#55

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

enisn
enisn approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enisn
Copy link
Contributor

enisn commented Apr 12, 2021

Also closes #55

@furkandeveloper furkandeveloper self-requested a review April 12, 2021 18:21
@furkandeveloper
Copy link
Owner

Hi @emrekara37 👋

Firstly thank you for contribution on EasyProfiler. Currently have not problem but I will examine it a little more.

Happy Coding ! @emrekara37 ✨🎉

@furkandeveloper
Copy link
Owner

LGTM

Thank you for review @enisn ✌

@furkandeveloper furkandeveloper self-assigned this Apr 12, 2021
@furkandeveloper furkandeveloper added enhancement New feature or request pull_request labels Apr 12, 2021
@furkandeveloper furkandeveloper linked an issue Apr 12, 2021 that may be closed by this pull request
✨[FEATURE] SQLite Support #55
Open
@furkandeveloper
Copy link
Owner

Hi @emrekara37,
I am sorry for waited for this PR.
But EasyProfiler has been changed of architectural.

Therefore take a new fork and update the implementation for the PR below.

EasyProfiler waiting for new feature.
Happy Coding ✨🎉✌
fyi @enisn

@enisn
Copy link
Contributor

enisn commented Apr 19, 2021

If there is a branch that is able to merge this PR, I can work on it.
Because Architectural changes are major and might have breaking changes.

I think @emrekara37 can solve conflict and re-open PR. SQLite implementation won't be affected much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisn enisn enisn approved these changes

@furkandeveloper furkandeveloper Awaiting requested review from furkandeveloper

Assignees

@furkandeveloper furkandeveloper

Labels
enhancement New feature or request pull_request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[FEATURE] SQLite Support
3 participants
@emrekara37 @enisn @furkandeveloper