Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A proposal for "previous", "current" and "next" screenshots symlinks #59

Open
selliott512 opened this issue Feb 3, 2024 · 3 comments
Open

Comments

@selliott512
Copy link
Contributor

For the 0.13.0 release I had a significant amount of changes tied up in my "bump" branches, which I think was suboptimal since it made the changes less transparent. It also increased the odds of merge conflicts. Included in that "significant amount of changes" is the 0.13.0 screenshots.

What if for screenshots we had subdirectories named after versions and symlinks that pointed to them.

  • 0.12.0
  • 0.13.0
  • 0.14.0
  • previous -> 0.12.0
  • current -> 0.13.0
  • next -> 0.14.0

That way the release process, in the "bump" branch, would simply be a matter of renaming the symlinks, a lightweight process that won't have merge conflicts.

This has makes it possible to:

  • Review the screenshots locally just by reaming the symlink.
  • Add new screenshots for the next release in master, as they are created.
  • Know which version each screenshot is for.

I have "previous" in my example, but we don't need to have that. We could just delete old releases.

I know one goal is to have simple permanent links for screenshots. This would allow for that, but with "current" added to the URL:

https://freedoom.github.io/img/screenshots/current/p2_1.png
@mc776
Copy link
Contributor

mc776 commented Feb 3, 2024

I think this would create more work than it would avoid, and the work created would be harder to notice when it's not done (and harder for non-technically-inclined people to realize needs to be done) than the work required by just direclty overwriting the old image file each time.

@selliott512
Copy link
Contributor Author

That's fine. If we want to have an internal review of the new screenshots people can just checkout the branch and look at it.

@mc776
Copy link
Contributor

mc776 commented Feb 4, 2024

That's what I'm thinking... and if we don't want to have people relying on repository stuff (which can be a bit daunting) the best, most user/future-maintainer-friendly way to do an archive of old screenshots is to have a dedicated page linking to pics with the version number in their filenames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants