Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning parameters #1

Open
topepo opened this issue Jul 22, 2024 · 2 comments
Open

Tuning parameters #1

topepo opened this issue Jul 22, 2024 · 2 comments
Labels
dials parameter tuning and naming

Comments

@topepo
Copy link

topepo commented Jul 22, 2024

We're super happy that you made this.

I can put a PR into dials for the new tuning parameters (if you like) or you could take a dials+scales dependency and add them here.

Also, we should modify a few things related to tuning parameters.

  • laplace_sigma references dials::svm_margin (prob copy/paste issue)
  • I think svm_anova_rbf should point to dials::degree_int(). Probably the same for the Bessel kernel and maybe order? ¯_(ツ)_/¯ (I'll do some testing)

I can have a PR for these in short order too.

@frankiethull
Copy link
Owner

I am super happy that you are here helping me out :)

This was a big learning opportunity for me and appreciate the tidymodels team even more now.

I had started with the svm_laplace, actually a one-off fcn svm_laplacian just so I could figure out how parsnip bindings work. Then decided to build a full-on package since I had a name in mind. I thought I had fixed the reference issue (as a few others in laplace) but was moving fast.

As for parameter naming and where to point, I am fine with changing those parameter names. Let me know how the tests go and thank you for helping with the maize dependencies as well.

@frankiethull
Copy link
Owner

@topepo - I added a handful of special kernels with a few more I'd like to implement. these are really fun to play with! I was hoping for advice on the additional tuning parameters and see what your thoughts were.

@frankiethull frankiethull added the dials parameter tuning and naming label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dials parameter tuning and naming
Projects
None yet
Development

No branches or pull requests

2 participants