You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am super happy that you are here helping me out :)
This was a big learning opportunity for me and appreciate the tidymodels team even more now.
I had started with the svm_laplace, actually a one-off fcn svm_laplacian just so I could figure out how parsnip bindings work. Then decided to build a full-on package since I had a name in mind. I thought I had fixed the reference issue (as a few others in laplace) but was moving fast.
As for parameter naming and where to point, I am fine with changing those parameter names. Let me know how the tests go and thank you for helping with the maize dependencies as well.
@topepo - I added a handful of special kernels with a few more I'd like to implement. these are really fun to play with! I was hoping for advice on the additional tuning parameters and see what your thoughts were.
We're super happy that you made this.
I can put a PR into dials for the new tuning parameters (if you like) or you could take a dials+scales dependency and add them here.
Also, we should modify a few things related to tuning parameters.
laplace_sigma
referencesdials::svm_margin
(prob copy/paste issue)svm_anova_rbf
should point todials::degree_int()
. Probably the same for the Bessel kernel and maybeorder
? ¯_(ツ)_/¯ (I'll do some testing)I can have a PR for these in short order too.
The text was updated successfully, but these errors were encountered: