Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ci): uploaded artefacts not pinned to specific GCC version #1044

Closed
gnikit opened this issue Jun 3, 2024 · 2 comments · Fixed by #985
Closed

bug(ci): uploaded artefacts not pinned to specific GCC version #1044

gnikit opened this issue Jun 3, 2024 · 2 comments · Fixed by #985
Assignees

Comments

@gnikit
Copy link
Member

gnikit commented Jun 3, 2024

With the introduction of multiple GCC versions in our CI/CD pipelines we ended up in a situation where the upload/download artefacts have the same name and consequently the upload/download (v3) GitHub Actions would pick the last created artefact as the one to be listed in our CD and Release Notes. Which artefact is generated last varies from run to run.

This currently works because there are no (major?!) ABI changes between GFortran 10 through 12, however we can't expect this to always be the case.

This issue was originally uncovered as part of the dependabot PR #985, where now upload artefacts must have unique names.

I propose that for the time being the artefacts that we provide as part of our CD are based on the oldest supported version of GFortran, in this case GFortran-10. @awvwgk and @perazz any thoughts on this?

This should get fixed as part of #985.

@gnikit gnikit self-assigned this Jun 3, 2024
@awvwgk
Copy link
Member

awvwgk commented Jun 4, 2024

Can we include the compiler version in the artifact name? For the upload we can specify which compiler version we want exactly.

@gnikit
Copy link
Member Author

gnikit commented Jun 4, 2024

Can we include the compiler version in the artifact name?

Yes, my changes should already be in effect in the dependabot PR.

For the upload we can specify which compiler version we want exactly.

Yes, that's my thinking as well. Should we choose the oldest GCC version for that?

@gnikit gnikit linked a pull request Jun 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants