Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/pupil bench issues #60

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Bugfix/pupil bench issues #60

merged 2 commits into from
Apr 15, 2020

Conversation

eozd
Copy link
Collaborator

@eozd eozd commented Apr 15, 2020

Partially fixes #59 .

Changes proposed in this pull request:

  • Fix valid fixations crash
  • Change pfe C_z parameter to a value closer to ground truth
  • Update documentation

@eozd eozd added bug Something isn't working documentation Issue related to documentation enhancement Some minor improvement fixed The issue has been fixed labels Apr 15, 2020
@eozd eozd added this to the v0.1.0 milestone Apr 15, 2020
@eozd eozd merged commit c5dde54 into develop Apr 15, 2020
@eozd eozd deleted the bugfix/pupil-bench-issues branch April 15, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working documentation Issue related to documentation enhancement Some minor improvement fixed The issue has been fixed
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

List of issues with pupil benchmarking
1 participant
@eozd