Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interactive testing logic #38

Open
eozd opened this issue Dec 9, 2019 · 1 comment
Open

Refactor interactive testing logic #38

eozd opened this issue Dec 9, 2019 · 1 comment
Assignees
@eozd
Labels
change request Some part should be different enhancement Some minor improvement
Milestone
v0.1.0

Comments

@eozd
Copy link
Collaborator

eozd commented Dec 9, 2019

Feature Description

Interactive testing logic is being duplicated in a couple of places, some of which are InteractiveTest and ReinforcementLearningFittingMixin classes. We should consider refactoring it somehow.
@eozd eozd added enhancement Some minor improvement change request Some part should be different new feature A full-fledged feature request labels Dec 9, 2019
@eozd eozd added this to the v0.1.0 milestone Dec 9, 2019
@eozd eozd self-assigned this Dec 9, 2019
@eozd eozd mentioned this issue Dec 9, 2019
Closed
@eozd eozd removed the new feature A full-fledged feature request label Jan 20, 2020
@eozd
Copy link
Collaborator Author

eozd commented Jan 20, 2020

In the current version, this logic is in three places: testing.InteractiveTest, simulation.simulate and models.PolicyModel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eozd eozd

Labels
change request Some part should be different enhancement Some minor improvement
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@eozd