Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab Provider adds commit status for every reconciliation #1009

Open
mo-rieger opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1010
Open

GitLab Provider adds commit status for every reconciliation #1009

mo-rieger opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1010

Comments

@mo-rieger
Copy link

mo-rieger commented Dec 19, 2024 •
edited
Loading

The GitLab Provider continuously adds commit statuses for every reconciliation.

This happens only for projects with more than 20 jobs. The GitLab Provider code already has some logic to prevent adding a commit status if one already exists. Still, it only considers the first 20 commit statuses because it is a paginated request that defaults to 20.

The impact of this bug is quite heavy. Thousands of commit statuses considered "external jobs" in the GitLab UI have piled up, with every new job triggering some GitLab background processes, nearly bringing down our GitLab instance.
mo-rieger pushed a commit to mo-rieger/notification-controller that referenced this issue Dec 19, 2024
fix: adding of duplicate commit statuses in gitlab
7310c11 
RESOLVES fluxcd#1009
@mo-rieger mo-rieger linked a pull request Dec 19, 2024 that will close this issue
Open
mo-rieger pushed a commit to mo-rieger/notification-controller that referenced this issue Dec 19, 2024
fix: adding of duplicate commit statuses in gitlab
6a84e2e 
RESOLVES fluxcd#1009
mo-rieger pushed a commit to mo-rieger/notification-controller that referenced this issue Dec 20, 2024
fix: adding of duplicate commit statuses in gitlab
69c9d12 
RESOLVES fluxcd#1009

Signed-off-by: Moritz Rieger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adding of duplicate commit statuses in gitlab mo-rieger/notification-controller
1 participant
@mo-rieger