Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.google.android.play:core for Android 14 Google target #91

Open
jonas2808 opened this issue Jun 19, 2024 · 5 comments
Open

Comments

@jonas2808
Copy link

For apps targeting Android 14 and using app_review plugin, the Google Play Console API is sending warnings to migrate com.google.android.play:core like in the tutorial: https://developer.android.com/guide/playcore?hl=de#playcore-migration

https://github.com/fluttercommunity/app_review/blob/master/android/build.gradle#L38

@1394813277
Copy link

Same issue.

@ambr89
Copy link

ambr89 commented Jun 21, 2024

same for me

@filiph
Copy link

filiph commented Jun 21, 2024

FWIW, here's the migration steps as I understand them, in case it's helpful:

Step 1

Replace play.core.tasks with gms.tasks in these import lines

import com.google.android.play.core.tasks.OnCompleteListener;
import com.google.android.play.core.tasks.Task;

Step 2

Depend on the newly separate Play in-app review library in android/build.gradle (here?).

dependencies {
    // This dependency is downloaded from the [Google’s Maven repository](https://developer.android.com/studio/build/dependencies#google-maven).
    // Make sure you also include that repository in your project's build.gradle file.
    implementation 'com.google.android.play:review:2.0.1'
}

@honzasima
Copy link

You can temporarily use my repository:

dependency_overrides:
  app_review:
    git:
      url: https://github.com/honzasima/app_review.git
      ref: updated_play_core

@chriscarman-mp
Copy link

Following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants