Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming issue of itemSize and itemSizeRange #176

Open
flekschas opened this issue Mar 29, 2020 · 1 comment
Open

Fix naming issue of itemSize and itemSizeRange #176

flekschas opened this issue Mar 29, 2020 · 1 comment
Assignees
Labels
documentation Coding: documentation

Comments

@flekschas
Copy link
Owner

As a new user I would assume itemSize defines the size of an item but it's actually the maximum size of the longer side of an item.

For itemSizeRange I would assume that it's the actual range of the sizes, e.g., 10px to 100px but in reality, it's the relative shrinkage. Since we decoupled itemSize from cellSize there's no need to redefine the max size via itemSizeRange.

I propose that we merge the two properties and just call them itemSize. If itemSize is a single number than the longer side of all items should be equal. if itemSize is an array we should treat it as a range. The array should hereby be absolute pixel values to not make things even more confusing. So 16 would mean that all items are at most 16px high or wide. [16,32] would linearly scale items to be at most 16 to 32 pixels high or wide.

@eeeeenchanted what do you think?

@flekschas flekschas added the documentation Coding: documentation label Mar 29, 2020
@flekschas flekschas self-assigned this Mar 29, 2020
@eeeeenchanted
Copy link
Collaborator

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Coding: documentation
Projects
None yet
Development

No branches or pull requests

2 participants