Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also package git? #103

Open
TobTobXX opened this issue May 9, 2022 · 3 comments
Open

Also package git? #103

TobTobXX opened this issue May 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@TobTobXX
Copy link

TobTobXX commented May 9, 2022

VCS doesn't work inside the flatpak, because the git binary is missing I think.

What's the opinion on packaging it?

@Calinou Calinou added the enhancement New feature or request label Aug 6, 2022
@Calinou
Copy link
Collaborator

Calinou commented Aug 6, 2022

What's the opinion on packaging it?

It might be better to patch the VCS library to allow using a custom Git command and arguments, so flatpak-run can be used instead to call system Git.

@lw64
Copy link

lw64 commented Jun 4, 2023

I think the best way would be to use use org.freedesktop.Sdk as the flatpak runtime. It includes among other useful things also git. A lot of other development oriented apps also use sdks as the runtime, so this is 100% supported. I think the godot flatpak should rely as little as possible on certain executables on the host. It needs to be set up before it works and also installing something like git is not possible (or not recommended) on read-only operating systems like for example fedora silverblue.

@Zishan-Rahman
Copy link
Contributor

Zishan-Rahman commented Jul 12, 2024

Now that we're using org.freedesktop.Sdk as the Flatpak runtime now, Git with Godot hopefully should work, and if it does work then we can close this issue, but I haven't tested this in a long while. Until I get to that, if anyone else wants to try this out, I'm more than happy for you to do so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants