This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just now seeing theres a build error, will check that out shortly |
hey @Ruteri , didn't have time to fix this test failure over the holidays but curious if y'all are interested in this PR? If not I can submit another w/ just the mutex change. |
Ruteri
reviewed
Jan 3, 2023
return nil | ||
} | ||
|
||
func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) []types.MevBundle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm, not sure if moving the txpool parts in the additional file won't be prone to later rebase issues and confusion
I think the changes are worthwile, and if you fix the build issues we'll merge |
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* do not fetch bundle if empty block num during the startup
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* do not fetch bundle if empty block num during the startup
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* do not fetch bundle if empty block num during the startup
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* do not fetch bundle if empty block num during the startup
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* do not fetch bundle if empty block num during the startup
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* do not fetch bundle if empty block num during the startup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
What
This PR has 2 main changes:
core/tx_pool.go
intocore/bundle_pool.go
.Why
core/tx_pool.go
is shared by other functions in the txpool. Depending on your mempool size this could cut locks considerably.Testing
📚 References
#7
CONTRIBUTING.md