assign
for AllAtOnceFunction
and AllAtOnceCofunction
should use _vs_op
for all sources.
#159
Labels
assign
for AllAtOnceFunction
and AllAtOnceCofunction
should use _vs_op
for all sources.
#159
In #158 I tried to change the
assign
implementation to just use the_vs_op
utility method to reuse the logic for dealing with assigning from anotherAllAtOnceFunction
, aVec
, or aFunction
. This passes allassign
tests.However,
test_allatoncesolver::test_solve_heat_equation
fails if_vs_op
is used to assign from aVec
. The only difference is whether theaaofunc.global_vec
is accessed via read/write access or just write access. This shouldn't make a difference because the vec is overwritten with the new value anyway, but it makes the test fail.For the time being I've just left the old
assign
implementation forVec
. Although using_vs_op
is just a nice way of reusing code, we should track down why it fails because there may be some other underlying issue.The text was updated successfully, but these errors were encountered: