You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🚀 Feature
Parsing methods like Image._parse_affine, Image._parse_tensor and Image._read_and_check currently don't touch the class state (via self). As they only do input validation, they also shouldn't.
To prevent this entirely and especially making it easier to test these when they are overwritten, to me it makes sense to make those functions completely static.
🚀 Feature
Parsing methods like
Image._parse_affine
,Image._parse_tensor
andImage._read_and_check
currently don't touch the class state (viaself
). As they only do input validation, they also shouldn't.To prevent this entirely and especially making it easier to test these when they are overwritten, to me it makes sense to make those functions completely static.
What do you think @fepegar ?
Note: This probably doesn't matter when using the built-in image classes, but heavily impacts testability for custom classes.
The text was updated successfully, but these errors were encountered: