Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub information with no user name shows a blank name in the views #317

Open
arielj opened this issue Nov 1, 2023 · 1 comment
Open
Labels
Bug Something isn't working

Comments

@arielj
Copy link
Contributor

arielj commented Nov 1, 2023

Branch/Commit:

Main branch.

Expected behavior:

When a GitHub user information is missing the name, we should fallback to other information, like the github handle.

Actual behavior:

When the Github user name is empty, the name is blank:
image

Steps to reproduce:

How do I achieve this behavior? Use the following format to provide a step-by-step guide:

  1. Log in into Points with a Github user that has no name
  2. Add some estimates
  3. Go to the report page

Also, add comments to a story, in the comments we also use the user's name.

Aditional information

We'll probably need to update the ombu_labs-auth game for this https://github.com/fastruby/ombu_labs-auth/blob/main/app/models/concerns/ombu_labs_authenticable.rb#L16

I will abide by the code of conduct

@arielj arielj added the Bug Something isn't working label Nov 1, 2023
@JuanVqz
Copy link
Member

JuanVqz commented Nov 1, 2023

This was also happening when adding comments in the stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants