Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

"maxlen" in parlai.core.torch_agent.History actually does nothing #3013

Open
Reveyer opened this issue Aug 26, 2020 · 2 comments
Open

"maxlen" in parlai.core.torch_agent.History actually does nothing #3013

Reveyer opened this issue Aug 26, 2020 · 2 comments
Labels
Help Wanted Minor never-stale

Comments

@Reveyer
Copy link
Contributor

Reveyer commented Aug 26, 2020

ParlAI/parlai/core/torch_agent.py

Line 209 in c7f4b64

self.max_len = maxlen

I think the description

  • maxlen – sets the maximum number of tunrs

should be changed to

  • size – sets the maximum number of tunrs
@stephenroller
Copy link
Contributor

Good catch. I’d welcome a PR

@github-actions
Copy link

This issue has not had activity in 30 days. Please feel free to reopen if you have more issues. You may apply the "never-stale" tag to prevent this from happening.

@github-actions github-actions bot added the stale label Sep 27, 2020
@github-actions github-actions bot closed this as completed Oct 4, 2020
@stephenroller stephenroller reopened this Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted Minor never-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenroller @klshuster @Reveyer