Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to review patches in Debian (v9.3.1+) #13162

Open
ottok opened this issue Nov 27, 2024 · 1 comment
Open

Request to review patches in Debian (v9.3.1+) #13162

ottok opened this issue Nov 27, 2024 · 1 comment

Comments

@ottok
Copy link
Contributor

ottok commented Nov 27, 2024

Could some RocksDB skim through the patches currently carried in Debian (overview https://udd.debian.org/patches.cgi?src=rocksdb&version=9.3.1-1, code https://salsa.debian.org/debian/rocksdb/-/tree/debian/latest/debian/patches) and let me know which ones you at upstream have interest in?

I could then put in effort to encourage the authors to submit them to RocksDB. For some reason none of them has been submitted upstream so far.
ottok added a commit to ottok/rocksdb that referenced this issue Dec 12, 2024
@ottok
Update changelog and refresh patches after 9.8.4 import
7dbb977 
- Drop loongarch patch that no longer applied. The patch was never
  submitted upstream, so original submitter will need to reassess it now
  and submit upstream first.

- Drop the zstd include patch that was already disabled and not in use.

In the long run each patch should be submitted upstream, there is no point
in trying to maintain them permanently in Debian. Upstream was contacted
in facebook#13162.
ottok added a commit to ottok/rocksdb that referenced this issue Dec 12, 2024
@ottok
Update changelog and refresh patches after 9.8.4 import
363fe81 
- Drop loongarch patch that no longer applied. The patch was never
  submitted upstream, so original submitter will need to reassess it now
  and submit upstream first.

- Drop the zstd include patch that was already disabled and not in use.

In the long run each patch should be submitted upstream, there is no point
in trying to maintain them permanently in Debian. Upstream was contacted
in facebook#13162.
@ottok
Copy link
Contributor Author

ottok commented Dec 21, 2024

Here is the table from https://udd.debian.org/patches.cgi?src=rocksdb&version=9.3.1-1 in Markdown so that if anybody searches the RocksDB issues in GitHub for anything that was already fixed downstream in Debian, they are more likely to find this:

Patch Name Description
build_reproducible.patch diff --git a/Makefile b/Makefile index a98aa5b..e58088d 100
fix_db_test.patch limit block_size to 32 bit Make the block_size to 3 Gb only on i386 and mipsel
no_rpath.patch do not build tools with rpath These will be installed semi-manual to usr/bin and will use system libraries
library_version.patch
ppc64.patch implement support for musl/ppc64
armv7_support.patch [PATCH] #8609 Add armv7 support
mips.patch implement timer implementation for mips platform
arm.patch implement timer for arm >= v6
0001-replace-old-sync-with-new-atomic-builtin-equivalents.patch [PATCH] replace old sync with new atomic builtin equivalents Helps compiling with gcc on newer arches e.g. riscv32
rely-on-default-for-optimization-on-Power.patch Don't optimize without knowing the target system on Power
add-support-for-loong64.patch Fix compilation options for loong64 architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ottok