Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU gaussian sorting #1803

Open
Meakk opened this issue Dec 18, 2024 · 0 comments
Open

Add CPU gaussian sorting #1803

Meakk opened this issue Dec 18, 2024 · 0 comments
Labels
help wanted Please help with this issue! source:libf3d type:enhancement New feature or request
Milestone

Comments

@Meakk
Copy link
Member

Meakk commented Dec 18, 2024

Is your feature request related to a problem? Please describe.
When changing the camera orientation, it is required to sort the gaussians by depth in order to have a correct result.
Sorting is currently executed on the GPU using compute shaders.
However it's not supported on macOS and the GPU sorting can be slow on low-end GPUs.
Let's consider CPU sorting using vtkDepthSortPolyData

Gaussians visualization is done in vtkext\private\module\vtkF3DPointSplatMapper.cxx file, and sorting shader is executed in the method vtkF3DSplatMapperHelper::SortSplats

We probably need to rename the method to SortSplatsGPU and add a new SortSplatsCPU function. The CPU function could be enable on macOS only for now, but it would be useful to have a way to let the user select which backend to use.

@Meakk Meakk added type:enhancement New feature or request good first issue Good for newcomers source:libf3d labels Dec 18, 2024
@mwestphal mwestphal added help wanted Please help with this issue! and removed good first issue Good for newcomers labels Dec 18, 2024
@mwestphal mwestphal added this to F3D Dec 19, 2024
@mwestphal mwestphal moved this to Investigate in F3D Dec 19, 2024
@mwestphal mwestphal moved this from Investigate to To do in F3D Dec 19, 2024
@mwestphal mwestphal added this to the 3.2.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please help with this issue! source:libf3d type:enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants