Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted "substrCount" functions that existed to support PHP 5.0. #414

Open
kitrio opened this issue Aug 10, 2024 · 1 comment
Open

Deleted "substrCount" functions that existed to support PHP 5.0. #414

kitrio opened this issue Aug 10, 2024 · 1 comment

Comments

@kitrio
Copy link
Contributor

kitrio commented Aug 10, 2024 •
edited
Loading

This function compatible for php 5.0

So there is no need these days.

htmlpurifier/library/HTMLPurifier/Lexer/DirectLex.php

Line 354 in f0fbf51

protected function substrCount($haystack, $needle, $offset, $length)

@kitrio kitrio changed the title remove "substrCount" function to support php 5.0 Deleted "substrCount" functions that existed to support PHP 5.0. Aug 10, 2024
@ezyang
Copy link
Owner

ezyang commented Aug 12, 2024

sure, send a pr

kitrio added a commit to kitrio/htmlpurifier that referenced this issue Aug 15, 2024
@kitrio
Remove: ezyang#414 method substrCount
753f60f
ezyang added a commit that referenced this issue Nov 10, 2024
@kitrio @ezyang
refactor: #414 remove method substrCount (#415)
d515007 
Co-authored-by: Edward Z. Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @kitrio