Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PaLM #305

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Add support for PaLM #305

merged 5 commits into from
Oct 5, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Sep 25, 2023

Description

Add support for PaLM.

Corresponding documentation PR

explosion/spaCy#13018

Types of change

New feature.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added the feat/model Feature: models label Sep 25, 2023
@rmitsch rmitsch self-assigned this Sep 25, 2023
@rmitsch rmitsch added the Test external Run external tests label Sep 26, 2023
@rmitsch rmitsch marked this pull request as ready for review September 26, 2023 09:31
@rmitsch rmitsch merged commit fad5253 into main Oct 5, 2023
27 checks passed
@beornf
Copy link

beornf commented Oct 5, 2023

I tested using PaLM and noticed the model directory palm has not been imported here:

from . import anthropic, base, cohere, noop, openai
__all__ = [
"anthropic",
"base",
"cohere",
"openai",
"noop",
]

@rmitsch
Copy link
Collaborator Author

rmitsch commented Oct 5, 2023

Thanks for the heads-up! Will be fixed later today.

@rmitsch rmitsch deleted the feat/palm branch October 5, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/model Feature: models Test external Run external tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants