Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor/window Codegen always emits float *, which is incorrect for custom memories #742

Open
yamaguchi1024 opened this issue Nov 7, 2024 · 0 comments
Labels
C: Codegen The final C code generation S: Available Available to be worked upon T: Bug Something isn't working

Comments

@yamaguchi1024
Copy link
Member

  • @instr(x : f32[...] @ AVX2) gets compiled into (..., float *x) instead of (..., __mm256 x)
  • _data is correct, but the vanilla {dst} dictionary's C string is incorrect. It uses float * (or sth like that) as a member of window struct, instead of the respective hw memory
  • Maybe we should make use of mem (not just prim_type and shape) in window codegen
@yamaguchi1024 yamaguchi1024 added T: Bug Something isn't working C: Codegen The final C code generation S: Available Available to be worked upon labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Codegen The final C code generation S: Available Available to be worked upon T: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant