Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline_assign bugs #612

Open
yamaguchi1024 opened this issue Apr 5, 2024 · 1 comment
Open

Fix inline_assign bugs #612

yamaguchi1024 opened this issue Apr 5, 2024 · 1 comment
Labels
C: Scheduling The scheduling language and APIs T: Bug Something isn't working

Comments

@yamaguchi1024
Copy link
Member

  • I think inline_assign should not delete the inlined statement if the LHS of the inlined statement was a procedure argument. That'll change the procedure's output behavior.
  • inline_assign should look at the buffer indices, instead of conservatively failing on them

@skeqiqevian what do you think?
@yamaguchi1024 yamaguchi1024 added T: Bug Something isn't working C: Scheduling The scheduling language and APIs labels Apr 5, 2024
@SamirDroubi
Copy link
Collaborator

Fyi, I was already fixing some of these here
#566

@yamaguchi1024 yamaguchi1024 mentioned this issue Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Scheduling The scheduling language and APIs T: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yamaguchi1024 @SamirDroubi