config_test.go

package evergreen

import (
	"context"
	"os"
	"path/filepath"
	"reflect"
	"testing"

	"github.com/evergreen-ci/evergreen/util"
	"github.com/mongodb/grip/send"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"github.com/stretchr/testify/suite"
	"go.mongodb.org/mongo-driver/bson"
	"go.mongodb.org/mongo-driver/mongo/options"
	"go.opentelemetry.io/otel/trace/noop"
)

const (
	testDir = "config_test"
	// testSettings contains the default admin settings suitable for testing
	// that depends on the global environment.
	testSettings = "evg_settings.yml"
)

func testConfigFile() string {
	return filepath.Join(FindEvergreenHome(), testDir, testSettings)
}

// TestConfig creates test settings from a test config.
func testConfig() *Settings {
	settings, err := NewSettings(testConfigFile())
	if err != nil {
		panic(err)
	}

	if err = settings.Validate(); err != nil {
		panic(err)
	}

	return settings
}

// Checks that the test settings file can be parsed
// and returns a settings object.
func TestInitSettings(t *testing.T) {
	assert := assert.New(t)

	settings, err := NewSettings(filepath.Join(FindEvergreenHome(),
		"testdata", "mci_settings.yml"))
	assert.NoError(err, "Parsing a valid settings file should succeed")
	assert.NotNil(settings)
}

// Checks that trying to parse a non existent file returns non-nil err
func TestBadInit(t *testing.T) {
	assert := assert.New(t)

	settings, err := NewSettings(filepath.Join(FindEvergreenHome(),
		"testdata", "blahblah.yml"))

	assert.Error(err, "Parsing a nonexistent config file should cause an error")
	assert.Nil(settings)
}

type AdminSuite struct {
	env              Environment
	originalEnv      Environment
	originalSettings *Settings
	suite.Suite
}

func TestAdminSuite(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	configFile := os.Getenv("SETTINGS_OVERRIDE")
	if configFile == "" {
		configFile = testConfigFile()
	}

	originalEnv := GetEnvironment()
	originalSettings, err := GetConfig(ctx)
	require.NoError(t, err)

	env, err := NewEnvironment(ctx, configFile, "", "", nil, noop.NewTracerProvider())
	require.NoError(t, err)

	s := new(AdminSuite)
	s.env = env
	s.originalEnv = originalEnv
	s.originalSettings = originalSettings
	suite.Run(t, s)
}

func (s *AdminSuite) SetupTest() {
	SetEnvironment(s.env)
}

func (s *AdminSuite) TearDownTest() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	// Reset the global env and admin settings after modifications to avoid
	// affecting other tests that depend on the global test env.
	SetEnvironment(s.originalEnv)
	s.NoError(UpdateConfig(ctx, s.originalSettings))
}

func (s *AdminSuite) TestBanner() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	const bannerText = "hello evergreen users!"

	err := SetBanner(ctx, bannerText)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(bannerText, settings.Banner)

	err = SetBannerTheme(ctx, Important)
	s.NoError(err)
	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(Important, settings.BannerTheme)
}

func (s *AdminSuite) TestBaseConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := Settings{
		AWSInstanceRole:     "role",
		Banner:              "banner",
		BannerTheme:         Important,
		ConfigDir:           "cfg_dir",
		DomainName:          "example.com",
		Expansions:          map[string]string{"k2": "v2"},
		GithubPRCreatorOrg:  "org",
		GithubOrgs:          []string{"evergreen-ci"},
		LogPath:             "logpath",
		Plugins:             map[string]map[string]interface{}{"k4": {"k5": "v5"}},
		PprofPort:           "port",
		SSHKeyDirectory:     "/ssh_key_directory",
		SSHKeyPairs:         []SSHKeyPair{{Name: "key", Public: "public", Private: "private"}},
		ShutdownWaitSeconds: 15,
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config.AWSInstanceRole, settings.AWSInstanceRole)
	s.Equal(config.Banner, settings.Banner)
	s.Equal(config.BannerTheme, settings.BannerTheme)
	s.Equal(config.ConfigDir, settings.ConfigDir)
	s.Equal(config.DomainName, settings.DomainName)
	s.Equal(config.Expansions, settings.Expansions)
	s.Equal(config.GithubPRCreatorOrg, settings.GithubPRCreatorOrg)
	s.Equal(config.GithubOrgs, settings.GithubOrgs)
	s.Equal(config.LogPath, settings.LogPath)
	s.Equal(config.Plugins, settings.Plugins)
	s.Equal(config.PprofPort, settings.PprofPort)
	s.Equal(config.SSHKeyDirectory, settings.SSHKeyDirectory)
	s.Require().Len(settings.SSHKeyPairs, len(config.SSHKeyPairs))
	for i := 0; i < len(settings.SSHKeyPairs); i++ {
		s.Equal(config.SSHKeyPairs[i].Name, settings.SSHKeyPairs[i].Name)
		s.Equal(config.SSHKeyPairs[i].Public, settings.SSHKeyPairs[i].Public)
		s.Equal(config.SSHKeyPairs[i].Private, settings.SSHKeyPairs[i].Private)
		s.Empty(config.SSHKeyPairs[i].EC2Regions)
	}
	s.Equal(config.ShutdownWaitSeconds, settings.ShutdownWaitSeconds)
}

func (s *AdminSuite) TestServiceFlags() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	testFlags := ServiceFlags{}
	s.NotPanics(func() {
		v := reflect.ValueOf(&testFlags).Elem()
		for i := 0; i < v.NumField(); i++ {
			f := v.Field(i)
			f.SetBool(true)
		}
	})

	err := testFlags.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(testFlags, settings.ServiceFlags)

	s.NotPanics(func() {
		t := reflect.TypeOf(&settings.ServiceFlags).Elem()
		v := reflect.ValueOf(&settings.ServiceFlags).Elem()
		for i := 0; i < v.NumField(); i++ {
			f := v.Field(i)
			s.True(f.Bool(), "all fields should be true, but '%s' was false", t.Field(i).Name)
		}
	})
}

func (s *AdminSuite) TestAmboyConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := AmboyConfig{
		Name:                                  "amboy",
		SingleName:                            "single",
		PoolSizeLocal:                         10,
		PoolSizeRemote:                        20,
		LocalStorage:                          30,
		GroupDefaultWorkers:                   40,
		GroupBackgroundCreateFrequencyMinutes: 50,
		GroupPruneFrequencyMinutes:            60,
		GroupTTLMinutes:                       70,
		LockTimeoutMinutes:                    7,
		SampleSize:                            200,
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Amboy)
}

func (s *AdminSuite) TestAdminDBConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := AmboyDBConfig{
		URL:      "mongodb://localhost:27017",
		Database: "db",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.AmboyDB)
}

func (s *AdminSuite) TestApiConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := APIConfig{
		HttpListenAddr: "addr",
		URL:            "api",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Api)
}

func (s *AdminSuite) TestAuthConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := AuthConfig{
		Okta: &OktaConfig{
			ClientID:           "id",
			ClientSecret:       "secret",
			Issuer:             "issuer",
			Scopes:             []string{"openid", "email", "profile", "offline_access"},
			UserGroup:          "group",
			ExpireAfterMinutes: 60,
		},
		Naive: &NaiveAuthConfig{
			Users: []AuthUser{{Username: "user", Password: "pw"}},
		},
		Github: &GithubAuthConfig{
			ClientId:     "ghclient",
			ClientSecret: "ghsecret",
			Users:        []string{"ghuser"},
			Organization: "ghorg",
			AppId:        1234,
		},
		Multi: &MultiAuthConfig{
			ReadWrite: []string{AuthGithubKey},
		},
		Kanopy: &KanopyAuthConfig{
			HeaderName: "internal_header",
		},
		BackgroundReauthMinutes: 60,
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.AuthConfig)
}

func (s *AdminSuite) TestHostinitConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := HostInitConfig{
		HostThrottle: 64,
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.HostInit)
}

func (s *AdminSuite) TestJiraConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := JiraConfig{
		Host: "host",
		BasicAuthConfig: JiraBasicAuthConfig{
			Username: "username",
			Password: "password",
		},
		OAuth1Config: JiraOAuth1Config{
			PrivateKey:  "asdf",
			AccessToken: "fdsa",
		},
		Email: "a@mail.com",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Jira)
}

func (s *AdminSuite) TestPodLifecycleConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := PodLifecycleConfig{
		MaxParallelPodRequests:      1000,
		MaxPodDefinitionCleanupRate: 100,
		MaxSecretCleanupRate:        100,
	}

	err := config.Set(ctx)
	s.Require().NoError(err)
	settings, err := GetConfig(ctx)
	s.Require().NoError(err)
	s.Require().NotNil(settings)
	s.Equal(config, settings.PodLifecycle)
}

func (s *AdminSuite) TestParameterStoreConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := ParameterStoreConfig{
		Prefix: "/evergreen",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.ParameterStore)
}

func (s *AdminSuite) TestProvidersConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := CloudProviders{
		AWS: AWSConfig{
			EC2Keys: []EC2Key{
				{
					Secret: "aws_secret",
					Key:    "aws",
				},
			},
		},
		Docker: DockerConfig{
			APIVersion: "docker_version",
		},
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Providers)
}

func (s *AdminSuite) TestRepotrackerConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := RepoTrackerConfig{
		NumNewRepoRevisionsToFetch: 10,
		MaxRepoRevisionsToSearch:   20,
		MaxConcurrentRequests:      30,
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.RepoTracker)
}

func (s *AdminSuite) TestSchedulerConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := SchedulerConfig{
		TaskFinder: "task_finder",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Scheduler)
}

func (s *AdminSuite) TestSlackConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := SlackConfig{
		Options: &send.SlackOptions{
			Channel:   "channel",
			Fields:    true,
			FieldsSet: map[string]bool{},
		},
		Token: "token",
		Level: "info",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Slack)
}

func (s *AdminSuite) TestSplunkConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := SplunkConfig{
		SplunkConnectionInfo: send.SplunkConnectionInfo{
			ServerURL: "splunk_url",
			Token:     "splunk_token",
			Channel:   "splunk_channel",
		},
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Splunk)
}

func (s *AdminSuite) TestUiConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := UIConfig{
		Url:                "url",
		HelpUrl:            "helpurl",
		HttpListenAddr:     "addr",
		Secret:             "secret",
		DefaultProject:     "mci",
		CacheTemplates:     true,
		CsrfKey:            "csrf",
		StagingEnvironment: "mine",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Ui)
}

func (s *AdminSuite) TestConfigDefaults() {
	config := testConfig()

	s.Require().NotNil(config)
	config.Database = DBSettings{
		Url: "url",
		DB:  "db",
	}
	config.AuthConfig = AuthConfig{
		Naive: &NaiveAuthConfig{},
	}
	config.Ui = UIConfig{
		Secret:         "secret",
		DefaultProject: "proj",
		Url:            "url",
	}
	config.ConfigDir = "dir"
	config.ExpansionsNew = util.KeyValuePairSlice{
		{Key: "k1", Value: "v1"},
		{Key: "k2", Value: "v2"},
	}
	s.NoError(config.Validate())

	// spot check the defaults
	s.Equal("legacy", config.Scheduler.TaskFinder)
	s.Equal(defaultLogBufferingDuration, config.LoggerConfig.Buffer.DurationSeconds)
	s.Equal("info", config.LoggerConfig.DefaultLevel)
	s.Equal(defaultAmboyPoolSize, config.Amboy.PoolSizeLocal)
	s.Equal("v1", config.Expansions["k1"])
	s.Equal("v2", config.Expansions["k2"])
	for _, pair := range config.SSHKeyPairs {
		s.NotNil(pair.EC2Regions)
		s.Equal([]string{}, pair.EC2Regions)
	}
}

func (s *AdminSuite) TestKeyValPairsToMap() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := Settings{
		ConfigDir: "foo",
		ExpansionsNew: util.KeyValuePairSlice{
			{Key: "exp1key", Value: "exp1val"},
		},
		PluginsNew: util.KeyValuePairSlice{
			{Key: "myPlugin", Value: util.KeyValuePairSlice{
				{Key: "pluginKey", Value: "pluginVal"},
			}},
		},
	}
	s.NoError(config.ValidateAndDefault())
	s.NoError(config.Set(ctx))
	dbConfig := Settings{}
	s.NoError(dbConfig.Get(ctx))
	s.Len(dbConfig.ExpansionsNew, 1)
	s.Len(dbConfig.PluginsNew, 1)
	s.Equal(config.ExpansionsNew[0].Value, dbConfig.Expansions[config.ExpansionsNew[0].Key])
	pluginMap := dbConfig.Plugins[config.PluginsNew[0].Key]
	s.NotNil(pluginMap)
	s.Equal("pluginVal", pluginMap["pluginKey"])
}

func (s *AdminSuite) TestNotifyConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := NotifyConfig{
		SES: SESConfig{
			SenderAddress: "from",
		},
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Notify)

	config.BufferIntervalSeconds = 1
	config.BufferTargetPerInterval = 2
	s.NoError(config.Set(ctx))

	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Notify)
}

func (s *AdminSuite) TestLoggerConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := LoggerConfig{
		RedactKeys: []string{
			"secret",
			"github token",
		},
	}
	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.LoggerConfig)
}

func (s *AdminSuite) TestContainerPoolsConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	invalidConfig := ContainerPoolsConfig{
		Pools: []ContainerPool{
			{
				Distro:        "d1",
				Id:            "test-pool-1",
				MaxContainers: -5,
			},
		},
	}

	err := invalidConfig.ValidateAndDefault()
	s.EqualError(err, "container pool max containers must be positive integer")

	validConfig := ContainerPoolsConfig{
		Pools: []ContainerPool{
			{
				Distro:        "d1",
				Id:            "test-pool-1",
				MaxContainers: 100,
			},
			{
				Distro:        "d2",
				Id:            "test-pool-2",
				MaxContainers: 1,
			},
		},
	}

	err = validConfig.Set(ctx)
	s.NoError(err)

	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(validConfig, settings.ContainerPools)

	validConfig.Pools[0].MaxContainers = 50
	s.NoError(validConfig.Set(ctx))

	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(validConfig, settings.ContainerPools)

	lookup := settings.ContainerPools.GetContainerPool("test-pool-1")
	s.NotNil(lookup)
	s.Equal(*lookup, validConfig.Pools[0])

	lookup = settings.ContainerPools.GetContainerPool("test-pool-2")
	s.NotNil(lookup)
	s.Equal(*lookup, validConfig.Pools[1])

	lookup = settings.ContainerPools.GetContainerPool("test-pool-3")
	s.Nil(lookup)
}

func (s *AdminSuite) TestJIRANotificationsConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	c := JIRANotificationsConfig{
		CustomFields: []JIRANotificationsProject{
			{
				Project: "this",
				Fields: []JIRANotificationsCustomField{
					{
						Field:    "should",
						Template: "disappear",
					},
				},
			},
		},
	}
	s.NoError(c.Get(ctx))
	s.NotNil(c)
	s.Nil(c.CustomFields)
	s.NotPanics(func() {
		s.NoError(c.ValidateAndDefault())
	})

	c.CustomFields = []JIRANotificationsProject{
		{
			Project: "EVG",
			Fields: []JIRANotificationsCustomField{
				{
					Field:    "customfield_12345",
					Template: "magical{{.Template.Expansion}}",
				},
			},
		},
	}
	s.Require().NoError(c.Set(ctx))

	c = JIRANotificationsConfig{}
	s.Require().NoError(c.Get(ctx))
	s.NoError(c.ValidateAndDefault())
	s.Len(c.CustomFields, 1)

	c = JIRANotificationsConfig{}
	s.NoError(c.Set(ctx))
	s.NoError(c.ValidateAndDefault())
	c.CustomFields = []JIRANotificationsProject{
		{
			Project: "this",
			Fields: []JIRANotificationsCustomField{
				{
					Field:    "is",
					Template: "{{.Invalid}",
				},
			},
		},
	}
	s.EqualError(c.ValidateAndDefault(), "template: this-is:1: bad character U+007D '}'")
}

func (s *AdminSuite) TestCommitQueueConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := CommitQueueConfig{
		MergeTaskDistro: "distro",
		CommitterName:   "Evergreen",
		CommitterEmail:  "evergreen@mongodb.com",
	}

	s.NoError(config.ValidateAndDefault())
	s.NoError(config.Set(ctx))

	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.Require().NotNil(settings)

	s.Equal(config, settings.CommitQueue)
}

func (s *AdminSuite) TestHostJasperConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	emptyConfig := HostJasperConfig{}
	s.NoError(emptyConfig.ValidateAndDefault())
	s.Equal(DefaultJasperPort, emptyConfig.Port)

	config := HostJasperConfig{
		BinaryName:       "foo",
		DownloadFileName: "bar",
		Port:             12345,
		URL:              "bat",
		Version:          "baz",
	}

	s.NoError(config.ValidateAndDefault())
	s.NoError(config.Set(ctx))

	settings, err := GetConfig(ctx)
	s.Require().NoError(err)

	s.Equal(config, settings.HostJasper)
}

func (s *AdminSuite) TestSleepScheduleConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	emptyConfig := SleepScheduleConfig{}
	s.NoError(emptyConfig.ValidateAndDefault())

	config := SleepScheduleConfig{
		PermanentlyExemptHosts: []string{"host0", "host1"},
	}

	s.NoError(config.ValidateAndDefault())
	s.NoError(config.Set(ctx))

	settings, err := GetConfig(ctx)
	s.Require().NoError(err)

	s.Equal(config, settings.SleepSchedule)
}

func (s *AdminSuite) TestAddEC2RegionToSSHKey() {
	env := GetEnvironment()
	ctx, cancel := env.Context()
	defer cancel()
	pairs := []SSHKeyPair{
		{
			Name:       "ssh_key_pair0",
			Public:     "public0",
			Private:    "private0",
			EC2Regions: []string{},
		},
		{
			Name:       "ssh_key_pair1",
			Public:     "public1",
			Private:    "private1",
			EC2Regions: []string{},
		},
	}
	coll := env.DB().Collection(ConfigCollection)
	_, err := coll.UpdateOne(ctx, bson.M{
		idKey: ConfigDocID,
	}, bson.M{
		"$set": bson.M{sshKeyPairsKey: pairs},
	}, options.Update().SetUpsert(true))
	s.Require().NoError(err)

	region0 := "region0"
	region1 := "region1"
	s.Require().NoError(pairs[0].AddEC2Region(region0))
	s.Contains(pairs[0].EC2Regions, region0)
	getDBPairs := func() []SSHKeyPair {
		dbSettings := &Settings{}
		s.Require().NoError(coll.FindOne(ctx, bson.M{
			idKey: ConfigDocID,
		}).Decode(dbSettings))
		return dbSettings.SSHKeyPairs
	}
	dbPairs := getDBPairs()
	s.Require().Len(dbPairs, 2)
	s.Require().Len(dbPairs[0].EC2Regions, 1)
	s.Equal(region0, dbPairs[0].EC2Regions[0])
	s.Empty(dbPairs[1].EC2Regions)

	s.Require().NoError(pairs[1].AddEC2Region(region1))
	dbPairs = getDBPairs()
	s.Require().Len(dbPairs, 2)
	s.Require().Len(dbPairs[0].EC2Regions, 1)
	s.Equal(region0, dbPairs[0].EC2Regions[0])
	s.Require().Len(dbPairs[1].EC2Regions, 1)
	s.Equal(region1, dbPairs[1].EC2Regions[0])

	s.Require().NoError(pairs[0].AddEC2Region(region0))
	dbPairs = getDBPairs()
	s.Require().Len(dbPairs, 2)
	s.Require().Len(dbPairs[0].EC2Regions, 1)
	s.Equal(region0, dbPairs[0].EC2Regions[0])
	s.Require().Len(dbPairs[1].EC2Regions, 1)
	s.Equal(region1, dbPairs[1].EC2Regions[0])

	s.Require().NoError(pairs[0].AddEC2Region(region1))
	dbPairs = getDBPairs()
	s.Require().Len(dbPairs, 2)
	s.Require().Len(dbPairs[0].EC2Regions, 2)
	s.Equal(region0, dbPairs[0].EC2Regions[0])
	s.Equal(region1, dbPairs[0].EC2Regions[1])
	s.Require().Len(dbPairs[1].EC2Regions, 1)
	s.Equal(region1, dbPairs[1].EC2Regions[0])
}

func (s *AdminSuite) TestSSHKeysAppendOnly() {
	defaultPair := func() SSHKeyPair {
		return SSHKeyPair{
			Name:    "foo",
			Public:  "public",
			Private: "private",
		}
	}

	env, ok := s.env.(*envState)
	s.Require().True(ok)
	oldSettings := env.settings

	settings := testConfig()
	settings.SSHKeyPairs = []SSHKeyPair{defaultPair()}
	settings.SSHKeyDirectory = "/ssh_key_directory"

	newSettings := testConfig()
	newSettings.SSHKeyPairs = []SSHKeyPair{defaultPair()}
	newSettings.SSHKeyDirectory = "/ssh_key_directory"

	env.settings = settings
	defer func() {
		env.settings = oldSettings
	}()

	pair := defaultPair()
	pair.Public = "new_public"
	newSettings.SSHKeyPairs = []SSHKeyPair{pair}
	s.Error(newSettings.Validate(), "should not be able to modify existing key pair")

	pair = defaultPair()
	pair.Private = "new_private"
	newSettings.SSHKeyPairs = []SSHKeyPair{pair}
	s.Error(newSettings.Validate(), "should not be able to modify existing key pair")

	pair = defaultPair()
	pair.Public = "new_public"
	pair.Private = "new_private"
	newSettings.SSHKeyPairs = []SSHKeyPair{defaultPair(), pair}
	s.Error(newSettings.Validate(), "should not be able to add a new pair with the same name and different public/private keys")

	newSettings.SSHKeyPairs = nil
	s.Error(newSettings.Validate(), "should not be able to delete existing key pair")

	newSettings.SSHKeyPairs = []SSHKeyPair{defaultPair(), {
		Name:    "bar",
		Public:  "public",
		Private: "private",
	}}
	s.NoError(newSettings.Validate(), "should be able to append new key pair")
}

func (s *AdminSuite) TestCedarConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := CedarConfig{
		BaseURL: "url.com",
		RPCPort: "9090",
		User:    "username",
		APIKey:  "key",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Cedar)

	config.RPCPort = "7070"
	s.NoError(config.Set(ctx))

	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Cedar)
}

func (s *AdminSuite) TestTracerConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := TracerConfig{
		Enabled:                   true,
		CollectorEndpoint:         "localhost:4316",
		CollectorInternalEndpoint: "svc.cluster.local:4317",
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Tracer)

	config.Enabled = false
	s.NoError(config.Set(ctx))

	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Tracer)
}

func (s *AdminSuite) TestBucketsConfig() {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	config := BucketsConfig{
		LogBucket: BucketConfig{
			Name: "logs",
			Type: "s3",
		},
	}

	err := config.Set(ctx)
	s.NoError(err)
	settings, err := GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Buckets)

	config.LogBucket.Name = "logs-2"
	s.NoError(config.Set(ctx))

	settings, err = GetConfig(ctx)
	s.NoError(err)
	s.NotNil(settings)
	s.Equal(config, settings.Buckets)
}