Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config File #7

Open
1 task
nprail opened this issue Sep 1, 2019 · 0 comments · May be fixed by #10
Open
1 task

Config File #7

nprail opened this issue Sep 1, 2019 · 0 comments · May be fixed by #10
Labels
enhancement New feature or request
Milestone

Comments

@nprail
Copy link
Member

nprail commented Sep 1, 2019

To support AAB upload (#4), reduce dependencies (adbkit-apkreader), and reduce command line parameters, a configuration file should be created. The config file should have a few static options including the package ID and location of the key.

Proposal

Location: apkup.json/apkup.js or specified via --config opt

Schema:

module.exports = {
   "packageName": "io.event1.app", // ID of the Android package
   "key": "./auth.json" // path to the Google API key
}

Questions

  • Should the key option be the key itself or a path to the key? I'm thinking it should be the path so that secrets and config are not mixed.
@nprail nprail added the enhancement New feature or request label Sep 1, 2019
@nprail nprail added this to the v2 milestone Sep 1, 2019
@nprail nprail linked a pull request Oct 5, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant