Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 17 Warnings - on Etso 1.1.2 #31

Open
chadfennell opened this issue Dec 2, 2024 · 0 comments
Open

Elixir 17 Warnings - on Etso 1.1.2 #31

chadfennell opened this issue Dec 2, 2024 · 0 comments

Comments

@chadfennell
Copy link

chadfennell commented Dec 2, 2024

Got a few compile time warnings on latest Elixir with Etso 1.1.2:

Erlang/OTP 27 [erts-15.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]
Elixir 1.17.3 (compiled with Erlang/OTP 27)
    warning: function delete/5 required by behaviour Ecto.Adapter.Schema is not implemented (in module Etso.Adapter)
    │
  1 │ defmodule Etso.Adapter do~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/etso/adapter.ex:1: Etso.Adapter (module)

    warning: function delete/5 required by behaviour Ecto.Adapter.Schema is not implemented (in module Etso.Adapter.Behaviour.Schema)
    │
  1 │ defmodule Etso.Adapter.Behaviour.Schema do~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/etso/adapter/behaviour/schema.ex:1: Etso.Adapter.Behaviour.Schema (module)

    warning: got "@impl Ecto.Adapter.Schema" for function delete/4 but this behaviour does not specify such callback. The known callbacks are:

      * Ecto.Adapter.Schema.autogenerate/1 (function)
      * Ecto.Adapter.Schema.delete/5 (function)
      * Ecto.Adapter.Schema.insert/6 (function)
      * Ecto.Adapter.Schema.insert_all/8 (function)
      * Ecto.Adapter.Schema.update/6 (function)

    │
 42 │   def delete(%{repo: repo}, %{schema: schema}, filters, _) do~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/etso/adapter/behaviour/schema.ex:42: Etso.Adapter.Behaviour.Schema (module)

    warning: got "@impl Ecto.Adapter.Schema" for function delete/4 but this behaviour does not specify such callback. The known callbacks are:

      * Ecto.Adapter.__before_compile__/1 (macro)
      * Ecto.Adapter.Schema.autogenerate/1 (function)
      * Ecto.Adapter.checked_out?/1 (function)
      * Ecto.Adapter.checkout/3 (function)
      * Ecto.Adapter.Schema.delete/5 (function)
      * Ecto.Adapter.dumpers/2 (function)
      * Ecto.Adapter.ensure_all_started/2 (function)
      * Ecto.Adapter.Queryable.execute/5 (function)
      * Ecto.Adapter.init/1 (function)
      * Ecto.Adapter.Schema.insert/6 (function)
      * Ecto.Adapter.Schema.insert_all/8 (function)
      * Ecto.Adapter.loaders/2 (function)
      * Ecto.Adapter.Queryable.prepare/2 (function)
      * Ecto.Adapter.Queryable.stream/5 (function)
      * Ecto.Adapter.Schema.update/6 (function)

    │
 65 │       def unquote(name)(unquote_splicing(args)) do~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/etso/adapter.ex:65: Etso.Adapter (module)
@chadfennell chadfennell changed the title Elixir 17 Warnings Elixir 17 Warnings - on Etso 1.1.2 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant