Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in nice error message for self-checkin-attempts #7

Open
RakanHowls opened this issue Sep 9, 2023 · 2 comments
Open

Fill in nice error message for self-checkin-attempts #7

RakanHowls opened this issue Sep 9, 2023 · 2 comments
Labels
enhancement New feature or request regdesk Reg-Desk software
Milestone

Comments

@RakanHowls
Copy link
Collaborator

When the API is updated to return a dedicated error code to show that the user is trying to do a self-check-in, a nice error message needs to be added

@RakanHowls RakanHowls added the enhancement New feature or request label Sep 9, 2023
@RakanHowls RakanHowls added this to the EF 28 milestone Sep 9, 2023
@RakanHowls RakanHowls added the regdesk Reg-Desk software label Sep 9, 2023
@dogpixels
Copy link
Member

Just out of curiosity, is this a security measure to prevent unauthorized check-ins?

@RakanHowls
Copy link
Collaborator Author

RakanHowls commented Sep 10, 2023

@dogpixels I don't know :) I was surprised and confused by the error message from the API myself when I tried it as a final test on the live system... :)

Unfortunately, with the available data from the IDP and RegSys APIs, I can't know with 100% certainty if someone is trying to check himself in (Nicknames can be different in the IDP vs. RegSys, and the RegSys doesn't provide IDP IDs), so I need a new error code / error details from the backend to properly display why the checkin fails in that case

@RakanHowls RakanHowls modified the milestones: EF 28, EF 29 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request regdesk Reg-Desk software
Projects
None yet
Development

No branches or pull requests

2 participants