Run all tests #1065
Open
Run all tests #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Dec 20, 2024
| @@ -27,7 +27,7 @@ | |||
| ETHEREUM_TESTS_PATH = TEST_FIXTURES["ethereum_tests"]["fixture_path"] | |||
|
|
|||
| # Run state tests | |||
| test_dir = f"{ETHEREUM_TESTS_PATH}/BlockchainTests/" | |||
| test_dir = f"{ETHEREUM_TESTS_PATH}/LegacyTests/Cancun/BlockchainTests/" | |||
There was a problem hiding this comment.
Just confirming this should be "Cancun" in the berlin fork.
There was a problem hiding this comment.
Yes. Frontier to Constantinople are under /LegacyTests/Constantinople and then Istanbul to Shanghai are under /LegacyTests/Cancun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( closes #1064 )
( closes #1028 )
What was wrong?
The ethereum/tests repository recently moved tests for forks earlier than Cancun into the LegacyTests. The testing code should be update to reflect this.
Related to Issue #1064
How was it fixed?
Update the test fixture path for pre-Cancun forks
Cute Animal Picture