Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EELS t8n return empty exception strings #1021

Open
winsvega opened this issue Oct 8, 2024 · 1 comment
Open

EELS t8n return empty exception strings #1021

winsvega opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers

Comments

@winsvega
Copy link
Contributor

winsvega commented Oct 8, 2024


{'body': '0xf84df84b800a82cf0780808025a00372ba5e45d0a0e636f7e32ffca16f97a2f3e4e930b6584b7b114ab3aa191b4fa04afdfcd2bc179e25c7aa74cb991a08f0ae6c01541a36f700be25c6f4c39bc098', 'alloc': {'0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b': {'balance': '0x3635c9adc5dea00000'}}, 'result': {'stateRoot': '0x70c42824108fafccadbfce71e6e22660c4fad89be18be324cd15ef351969a8c8', 'txRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'receiptsRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'withdrawalsRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'logsHash': '0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347', 'logsBloom': '0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 'gasUsed': '0x0', 'currentDifficulty': None, 'currentBaseFee': '0x7', 'rejected': [{'index': 0, 'error': 'Failed transaction: '}], 'receipts': []}}

message Failed transaction: is not sufficient enough to match exception code

the exception string is empty in line
src/ethereum_spec_tools/evm_tools/t8n/init.py

this probably goes to EELS repo
ethereum/execution-spec-tests#881

command:

uv run fill "tests/cancun/eip4844_blobs/test_blob_txs.py::test_insufficient_balance_blob_tx[fork_Cancun-blockchain_test--exact_balance_minus_1-tx_max_fee_per_blob_gas_1-no_calldata-tx_value_1-tx_max_priority_fee_per_gas_0-tx_max_fee_per_gas_7-no_access_list]"

Note to Implementer

Once all the specific exception types are being thrown correctly, make sure to update the test loader to take advantage:

# TODO: Once all the specific exception types are thrown,
# only `pytest.raises` the correct exception type instead of
# all of them.

@winsvega winsvega changed the title EELS t8n cut exception string in server mod EELS t8n return empty exception strings Oct 10, 2024
@SamWilsn SamWilsn self-assigned this Oct 10, 2024
@SamWilsn SamWilsn added A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers labels Oct 10, 2024
@SamWilsn
Copy link
Collaborator

SamWilsn added a commit to SamWilsn/eth1.0-specs that referenced this issue Oct 17, 2024
SamWilsn added a commit to SamWilsn/eth1.0-specs that referenced this issue Oct 17, 2024
SamWilsn added a commit to ethereum/ethereum-rlp that referenced this issue Nov 8, 2024
SamWilsn added a commit to ethereum/ethereum-rlp that referenced this issue Nov 8, 2024
SamWilsn added a commit to ethereum/ethereum-rlp that referenced this issue Nov 8, 2024
SamWilsn added a commit to SamWilsn/eth1.0-specs that referenced this issue Nov 11, 2024
SamWilsn added a commit to SamWilsn/eth1.0-specs that referenced this issue Nov 12, 2024
SamWilsn added a commit to SamWilsn/eth1.0-specs that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants