Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra variable and bitwise operation #13444

Open
BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Open

Extra variable and bitwise operation #13444

BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release

Comments

@BlocksOnAChain
Copy link

Description
This line does nothing. byteIndexMask is already &'ed with _vaddr.

Recommendation
Remove the line, and rename byteIndexMask to byteIndex.

packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
uint64 byteIndex = _vaddr & byteIndexMask;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release
Projects
Proofs team - Project Delivery tracking board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlocksOnAChain